From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31035 invoked by alias); 19 Apr 2008 02:08:56 -0000 Received: (qmail 31026 invoked by uid 22791); 19 Apr 2008 02:08:54 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 19 Apr 2008 02:08:32 +0000 Received: from mailhub1.br.ibm.com (unknown [9.18.232.109]) by igw3.br.ibm.com (Postfix) with ESMTP id 4517F39002D for ; Fri, 18 Apr 2008 22:55:13 -0300 (BRST) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m3J28UdP3993780 for ; Fri, 18 Apr 2008 23:08:30 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m3J28TRu029585 for ; Fri, 18 Apr 2008 23:08:29 -0300 Received: from [9.18.200.40] ([9.18.200.40]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m3J28TME029582; Fri, 18 Apr 2008 23:08:29 -0300 Subject: Re: [RFC] Remove exec_set_section_offsets From: Thiago Jung Bauermann To: Joel Brobecker Cc: GDB Patches In-Reply-To: <20080419015835.GN12735@adacore.com> References: <1208564244.5808.95.camel@localhost.localdomain> <20080419015835.GN12735@adacore.com> Content-Type: text/plain Date: Sat, 19 Apr 2008 04:28:00 -0000 Message-Id: <1208570812.5808.113.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00400.txt.bz2 On Fri, 2008-04-18 at 18:58 -0700, Joel Brobecker wrote: > > Perhaps it would qualify as obvious, but I'm not used to removing code > > from GDB so better ask about it... > > We just have to remember that insight builds on top of GDB. So, just > to be absolutely sure, I checked out the insight sources, and verified > that it wasn't using that function. So far, the functions I've seen > being used by insight started with a gdb_ prefix, but that might not > be a rule. Nice to know, thanks for the tip. So if I observe that, this kind of patch fits the obvious rule? > > 2008-04-18 Thiago Jung Bauermann > > > > * defs.h (exec_set_section_offsets): Remove prototype. > > * exec.c (exec_set_section_offsets): Remove function. > > That's OK. Thank you! Committed, thanks! -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center