Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@specifix.com>
To: Joel Brobecker <brobecker@adacore.com>,
	Daniel Jacobowitz <drow@false.org>
Cc: Greg Law <glaw@undo-software.com>, gdb-patches@sourceware.org
Subject: Re: gdb-6.8 branchpoint
Date: Wed, 27 Feb 2008 00:26:00 -0000	[thread overview]
Message-ID: <1204066796.19253.349.camel@localhost.localdomain> (raw)
In-Reply-To: <20080226223023.GB5326@adacore.com>

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

On Tue, 2008-02-26 at 14:30 -0800, Joel Brobecker wrote:
> > As per earlier on-list discussion, any chance of applying this simple 
> > fix to prevent random SEGV's in gdb?
> 
> Yes, this can go in the branch on the condition that it is approved
> by a Global Maintainer for HEAD first.

Sorry for joining the discussion late -- as noted on the 
original thread, I'd prefer to fix the problem at the 
reg_flush_command function as attached.  Certainly I meant
to do this when I wrote the darn thing.

Daniel?  This seem about right to you?



[-- Attachment #2: regcache.txt --]
[-- Type: text/plain, Size: 680 bytes --]

2008-02-26  Michael Snyder  <msnyder@specifix.com>

	* regcache.c (reg_flush_command): Void the frame cache as well
	as the registers cache.

Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.164
diff -p -r1.164 regcache.c
*** regcache.c	18 Feb 2008 16:37:17 -0000	1.164
--- regcache.c	26 Feb 2008 22:57:31 -0000
*************** reg_flush_command (char *command, int fr
*** 873,878 ****
--- 873,879 ----
  {
    /* Force-flush the register cache.  */
    registers_changed ();
+   reinit_frame_cache ();
    if (from_tty)
      printf_filtered (_("Register cache flushed.\n"));
  }

  reply	other threads:[~2008-02-26 23:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 21:54 Joel Brobecker
2008-02-26 21:57 ` Thiago Jung Bauermann
2008-02-26 22:25   ` Daniel Jacobowitz
2008-02-26 22:26     ` Thiago Jung Bauermann
2008-02-26 22:30   ` Joel Brobecker
2008-02-26 22:02 ` Greg Law
2008-02-26 22:37   ` Joel Brobecker
2008-02-27  0:26     ` Michael Snyder [this message]
2008-02-27  2:55     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204066796.19253.349.camel@localhost.localdomain \
    --to=msnyder@specifix.com \
    --cc=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=glaw@undo-software.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox