From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8896 invoked by alias); 26 Feb 2008 23:00:18 -0000 Received: (qmail 8884 invoked by uid 22791); 26 Feb 2008 23:00:15 -0000 X-Spam-Check-By: sourceware.org Received: from bluesmobile.specifix.com (HELO bluesmobile.specifix.com) (216.129.118.140) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Feb 2008 22:59:58 +0000 Received: from [127.0.0.1] (bluesmobile.specifix.com [216.129.118.140]) by bluesmobile.specifix.com (Postfix) with ESMTP id C02803BCEC; Tue, 26 Feb 2008 14:59:56 -0800 (PST) Subject: Re: gdb-6.8 branchpoint From: Michael Snyder To: Joel Brobecker , Daniel Jacobowitz Cc: Greg Law , gdb-patches@sourceware.org In-Reply-To: <20080226223023.GB5326@adacore.com> References: <20080226213741.GC3894@adacore.com> <47C48B2B.2040302@undo-software.com> <20080226223023.GB5326@adacore.com> Content-Type: multipart/mixed; boundary="=-PVVI0b/bgrMAPkFkKr6U" Date: Wed, 27 Feb 2008 00:26:00 -0000 Message-Id: <1204066796.19253.349.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-7.fc7) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00416.txt.bz2 --=-PVVI0b/bgrMAPkFkKr6U Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 542 On Tue, 2008-02-26 at 14:30 -0800, Joel Brobecker wrote: > > As per earlier on-list discussion, any chance of applying this simple > > fix to prevent random SEGV's in gdb? > > Yes, this can go in the branch on the condition that it is approved > by a Global Maintainer for HEAD first. Sorry for joining the discussion late -- as noted on the original thread, I'd prefer to fix the problem at the reg_flush_command function as attached. Certainly I meant to do this when I wrote the darn thing. Daniel? This seem about right to you? --=-PVVI0b/bgrMAPkFkKr6U Content-Disposition: attachment; filename=regcache.txt Content-Type: text/plain; name=regcache.txt; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 680 2008-02-26 Michael Snyder * regcache.c (reg_flush_command): Void the frame cache as well as the registers cache. Index: regcache.c =================================================================== RCS file: /cvs/src/src/gdb/regcache.c,v retrieving revision 1.164 diff -p -r1.164 regcache.c *** regcache.c 18 Feb 2008 16:37:17 -0000 1.164 --- regcache.c 26 Feb 2008 22:57:31 -0000 *************** reg_flush_command (char *command, int fr *** 873,878 **** --- 873,879 ---- { /* Force-flush the register cache. */ registers_changed (); + reinit_frame_cache (); if (from_tty) printf_filtered (_("Register cache flushed.\n")); } --=-PVVI0b/bgrMAPkFkKr6U--