From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix float argument passing in inferior function calls for ppc64
Date: Fri, 25 Jan 2008 15:58:00 -0000 [thread overview]
Message-ID: <1201275930.11950.120.camel@localhost.localdomain> (raw)
In-Reply-To: <1200487735.32125.0.camel@localhost.localdomain>
On Wed, 2008-01-16 at 10:48 -0200, Thiago Jung Bauermann wrote:
> On Tue, 2008-01-15 at 18:54 -0200, Thiago Jung Bauermann wrote:
> > On Tue, 2008-01-15 at 21:48 +0100, Mark Kettenis wrote:
> > > > From: Thiago Jung Bauermann <bauerman@br.ibm.com>
> > > > Date: Tue, 15 Jan 2008 18:33:54 -0200
> > > >
> > > > On Tue, 2008-01-15 at 15:39 -0200, Thiago Jung Bauermann wrote:
> > > > > > Is the first word used for anything in the new ABI? If not, you could
> > > > > > support both ABIs by copying the value into both the first and the
> > > > > > second word.
> > > > >
> > > > > Great idea. I will resend the patch using that approach then.
> > > >
> > > > What about this patch?
> > >
> > > Looks fine to me, but I have no means to test it.
> >
> > This is tested in Linux/ppc64.
> > I'll check this version for regressions (I only regtested the previous
> > patch).
>
> No regressions found. Ok to commit?
Ping?
I found an older Linux system here (from 2003 or 2004), and its GDB
implements the 1.7 ABI but still fails the test with many float
arguments, which means the 1.9 ABI is already in use.
Since current GDB CVS doesn't compile in that system anymore (actually
compilation failed in the bfd library), it also won't compile in an even
older system which would use the 1.7 ABI. Because of this, we shouldn't
worry too much about supporting the older ABI I think.
Still, my patch preserves compatibility with the 1.7 ABI while
implementing the 1.9 version. It's just that I wasn't able to test this
compatibility.
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2008-01-25 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 12:34 Thiago Jung Bauermann
2008-01-15 14:44 ` Mark Kettenis
2008-01-15 17:23 ` Jim Blandy
2008-01-15 17:40 ` Thiago Jung Bauermann
2008-01-15 20:34 ` Thiago Jung Bauermann
2008-01-15 20:48 ` Mark Kettenis
2008-01-15 20:55 ` Thiago Jung Bauermann
2008-01-16 12:49 ` Thiago Jung Bauermann
2008-01-16 14:45 ` Luis Machado
2008-01-25 15:58 ` Thiago Jung Bauermann [this message]
2008-01-25 16:06 ` Thiago Jung Bauermann
2008-01-31 22:12 ` Daniel Jacobowitz
2008-02-01 15:19 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1201275930.11950.120.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox