From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29863 invoked by alias); 25 Jan 2008 15:46:04 -0000 Received: (qmail 29849 invoked by uid 22791); 25 Jan 2008 15:46:03 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 25 Jan 2008 15:45:35 +0000 Received: from mailhub1.br.ibm.com (mailhub1 [9.18.232.109]) by igw1.br.ibm.com (Postfix) with ESMTP id A384332C404 for ; Fri, 25 Jan 2008 13:23:56 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m0PFjVaF4129020 for ; Fri, 25 Jan 2008 13:45:31 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m0PFjV4g020559 for ; Fri, 25 Jan 2008 13:45:31 -0200 Received: from [9.18.238.41] (dyn531774.br.ibm.com [9.18.238.41]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m0PFjVpG020554; Fri, 25 Jan 2008 13:45:31 -0200 Subject: Re: [RFA] Fix float argument passing in inferior function calls for ppc64 From: Thiago Jung Bauermann To: Mark Kettenis Cc: gdb-patches@sourceware.org In-Reply-To: <1200487735.32125.0.camel@localhost.localdomain> References: <1200400434.3158.64.camel@localhost.localdomain> <200801151443.m0FEhxN3021953@brahms.sibelius.xs4all.nl> <1200418789.3158.71.camel@localhost.localdomain> <1200429235.20287.10.camel@localhost.localdomain> <200801152048.m0FKm0rU027986@brahms.sibelius.xs4all.nl> <1200430477.10985.1.camel@localhost.localdomain> <1200487735.32125.0.camel@localhost.localdomain> Content-Type: text/plain Date: Fri, 25 Jan 2008 15:58:00 -0000 Message-Id: <1201275930.11950.120.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.2 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00610.txt.bz2 On Wed, 2008-01-16 at 10:48 -0200, Thiago Jung Bauermann wrote: > On Tue, 2008-01-15 at 18:54 -0200, Thiago Jung Bauermann wrote: > > On Tue, 2008-01-15 at 21:48 +0100, Mark Kettenis wrote: > > > > From: Thiago Jung Bauermann > > > > Date: Tue, 15 Jan 2008 18:33:54 -0200 > > > > > > > > On Tue, 2008-01-15 at 15:39 -0200, Thiago Jung Bauermann wrote: > > > > > > Is the first word used for anything in the new ABI? If not, you could > > > > > > support both ABIs by copying the value into both the first and the > > > > > > second word. > > > > > > > > > > Great idea. I will resend the patch using that approach then. > > > > > > > > What about this patch? > > > > > > Looks fine to me, but I have no means to test it. > > > > This is tested in Linux/ppc64. > > I'll check this version for regressions (I only regtested the previous > > patch). > > No regressions found. Ok to commit? Ping? I found an older Linux system here (from 2003 or 2004), and its GDB implements the 1.7 ABI but still fails the test with many float arguments, which means the 1.9 ABI is already in use. Since current GDB CVS doesn't compile in that system anymore (actually compilation failed in the bfd library), it also won't compile in an even older system which would use the 1.7 ABI. Because of this, we shouldn't worry too much about supporting the older ABI I think. Still, my patch preserves compatibility with the 1.7 ABI while implementing the 1.9 version. It's just that I wasn't able to test this compatibility. -- []'s Thiago Jung Bauermann Software Engineer IBM Linux Technology Center