Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Fix regression on watchpoints for PPC
Date: Fri, 09 Nov 2007 17:17:00 -0000	[thread overview]
Message-ID: <1194625057.4294.1.camel@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 94 bytes --]

Hi,

Daniel approved this patch in a discussion we had, so i've checked it
in.

Regards,
Luis

[-- Attachment #2: fix_ppc_watchpoints.diff --]
[-- Type: text/x-patch, Size: 634 bytes --]

2007-11-09  Luis Machado  <luisgpm@br.ibm.com>

	* ppc-linux-nat.c (ppc_linux_insert_watchpoint): Move 
	saved_dabr_value assignment to the correct position.

Index: gdb/ppc-linux-nat.c
===================================================================
--- gdb.orig/ppc-linux-nat.c	2007-11-09 08:36:34.000000000 -0800
+++ gdb/ppc-linux-nat.c	2007-11-09 08:45:43.000000000 -0800
@@ -831,10 +831,12 @@
       break;
     }
 
+  saved_dabr_value = dabr_value;
+
   ALL_LWPS (lp, ptid)
     if (ptrace (PTRACE_SET_DEBUGREG, TIDGET (ptid), 0, saved_dabr_value) < 0)
       return -1;
-  saved_dabr_value = dabr_value;
+
   return 0;
 }
 

                 reply	other threads:[~2007-11-09 17:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1194625057.4294.1.camel@localhost \
    --to=luisgpm@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox