From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28380 invoked by alias); 9 Nov 2007 17:17:52 -0000 Received: (qmail 28370 invoked by uid 22791); 9 Nov 2007 17:17:52 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Nov 2007 17:17:49 +0000 Received: from mailhub1.br.ibm.com (unknown [9.18.232.109]) by igw3.br.ibm.com (Postfix) with ESMTP id 35E313902B3 for ; Fri, 9 Nov 2007 15:10:32 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.6) with ESMTP id lA9HHihR1478822 for ; Fri, 9 Nov 2007 15:17:46 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lA9HHhG2003037 for ; Fri, 9 Nov 2007 15:17:43 -0200 Received: from [9.18.238.21] ([9.18.238.21]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lA9HHfJ0002935 for ; Fri, 9 Nov 2007 15:17:43 -0200 Subject: [PATCH] Fix regression on watchpoints for PPC From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="=-O4PryME0Fv5oRlbttAby" Date: Fri, 09 Nov 2007 17:17:00 -0000 Message-Id: <1194625057.4294.1.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00202.txt.bz2 --=-O4PryME0Fv5oRlbttAby Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 94 Hi, Daniel approved this patch in a discussion we had, so i've checked it in. Regards, Luis --=-O4PryME0Fv5oRlbttAby Content-Disposition: attachment; filename=fix_ppc_watchpoints.diff Content-Type: text/x-patch; name=fix_ppc_watchpoints.diff; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 634 2007-11-09 Luis Machado * ppc-linux-nat.c (ppc_linux_insert_watchpoint): Move saved_dabr_value assignment to the correct position. Index: gdb/ppc-linux-nat.c =================================================================== --- gdb.orig/ppc-linux-nat.c 2007-11-09 08:36:34.000000000 -0800 +++ gdb/ppc-linux-nat.c 2007-11-09 08:45:43.000000000 -0800 @@ -831,10 +831,12 @@ break; } + saved_dabr_value = dabr_value; + ALL_LWPS (lp, ptid) if (ptrace (PTRACE_SET_DEBUGREG, TIDGET (ptid), 0, saved_dabr_value) < 0) return -1; - saved_dabr_value = dabr_value; + return 0; } --=-O4PryME0Fv5oRlbttAby--