From: Richard Earnshaw <richard.earnshaw@buzzard.freeserve.co.uk>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix ARM big-endian struct arg passing
Date: Tue, 19 Jun 2007 22:42:00 -0000 [thread overview]
Message-ID: <1182292949.2790.8.camel@merlin> (raw)
In-Reply-To: <Pine.LNX.4.64.0706191808440.15926@digraph.polyomino.org.uk>
On Tue, 2007-06-19 at 18:11 +0000, Joseph S. Myers wrote:
> This patch fixes GDB incorrectly aligning part-register arguments on
> big-endian ARM. It changes the following tests from FAIL to PASS in
> testing with a cross to arm-linux-gnueabi (big-endian multilib); OK to
> commit?
>
> gdb.base/structs.exp: p/c L<n>; call 1 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 1 structs-ts
> gdb.base/structs.exp: p/c L<n>; call 10 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 11 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 13 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 14 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 15 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 2 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 3 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 3 structs-tc-ts
> gdb.base/structs.exp: p/c L<n>; call 3 structs-ts
> gdb.base/structs.exp: p/c L<n>; call 4 structs-ts-tc
> gdb.base/structs.exp: p/c L<n>; call 5 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 5 structs-tc-ts
> gdb.base/structs.exp: p/c L<n>; call 5 structs-ts
> gdb.base/structs.exp: p/c L<n>; call 5 structs-ts-tc
> gdb.base/structs.exp: p/c L<n>; call 6 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 7 structs-tc
> gdb.base/structs.exp: p/c L<n>; call 8 structs-ts-tc
> gdb.base/structs.exp: p/c L<n>; call 9 structs-tc
>
> 2007-06-19 Joseph Myers <joseph@codesourcery.com>
>
> * arm-tdep.c (arm_push_dummy_call): Correct padding of partial
> registers for big-endian.
OK.
R.
prev parent reply other threads:[~2007-06-19 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 18:11 Joseph S. Myers
2007-06-19 22:42 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182292949.2790.8.camel@merlin \
--to=richard.earnshaw@buzzard.freeserve.co.uk \
--cc=gdb-patches@sourceware.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox