From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4232 invoked by alias); 19 Jun 2007 22:42:40 -0000 Received: (qmail 4224 invoked by uid 22791); 19 Jun 2007 22:42:39 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.wanadoo.co.uk (HELO smtp1.freeserve.com) (193.252.22.158) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 19 Jun 2007 22:42:34 +0000 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf3008.me.freeserve.com (SMTP Server) with ESMTP id DD63A1C00085; Wed, 20 Jun 2007 00:42:31 +0200 (CEST) Received: from merlin.buzzard.freeserve.co.uk (user-5441719a.l6.c5.dsl.pol.co.uk [84.65.113.154]) by mwinf3008.me.freeserve.com (SMTP Server) with ESMTP id B14D81C00082; Wed, 20 Jun 2007 00:42:31 +0200 (CEST) X-ME-UUID: 20070619224231726.B14D81C00082@mwinf3008.me.freeserve.com Received: from merlin.buzzard.freeserve.co.uk (localhost [127.0.0.1]) by merlin.buzzard.freeserve.co.uk (8.13.8/8.13.8) with ESMTP id l5JMgUVD017974; Tue, 19 Jun 2007 23:42:30 +0100 (BST) Received: (from rearnsha@localhost) by merlin.buzzard.freeserve.co.uk (8.13.8/8.13.8/Submit) id l5JMgTpD006597; Tue, 19 Jun 2007 23:42:29 +0100 (BST) Subject: Re: Fix ARM big-endian struct arg passing From: Richard Earnshaw To: "Joseph S. Myers" Cc: gdb-patches@sourceware.org In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 19 Jun 2007 22:42:00 -0000 Message-Id: <1182292949.2790.8.camel@merlin> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0nb3 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00380.txt.bz2 On Tue, 2007-06-19 at 18:11 +0000, Joseph S. Myers wrote: > This patch fixes GDB incorrectly aligning part-register arguments on > big-endian ARM. It changes the following tests from FAIL to PASS in > testing with a cross to arm-linux-gnueabi (big-endian multilib); OK to > commit? > > gdb.base/structs.exp: p/c L; call 1 structs-tc > gdb.base/structs.exp: p/c L; call 1 structs-ts > gdb.base/structs.exp: p/c L; call 10 structs-tc > gdb.base/structs.exp: p/c L; call 11 structs-tc > gdb.base/structs.exp: p/c L; call 13 structs-tc > gdb.base/structs.exp: p/c L; call 14 structs-tc > gdb.base/structs.exp: p/c L; call 15 structs-tc > gdb.base/structs.exp: p/c L; call 2 structs-tc > gdb.base/structs.exp: p/c L; call 3 structs-tc > gdb.base/structs.exp: p/c L; call 3 structs-tc-ts > gdb.base/structs.exp: p/c L; call 3 structs-ts > gdb.base/structs.exp: p/c L; call 4 structs-ts-tc > gdb.base/structs.exp: p/c L; call 5 structs-tc > gdb.base/structs.exp: p/c L; call 5 structs-tc-ts > gdb.base/structs.exp: p/c L; call 5 structs-ts > gdb.base/structs.exp: p/c L; call 5 structs-ts-tc > gdb.base/structs.exp: p/c L; call 6 structs-tc > gdb.base/structs.exp: p/c L; call 7 structs-tc > gdb.base/structs.exp: p/c L; call 8 structs-ts-tc > gdb.base/structs.exp: p/c L; call 9 structs-tc > > 2007-06-19 Joseph Myers > > * arm-tdep.c (arm_push_dummy_call): Correct padding of partial > registers for big-endian. OK. R.