Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <Michael.Snyder@palmsource.com>
To: Jon Ringle <jon@ringle.org>
Cc: gdb-patches@sourceware.org
Subject: Re: gdbserver: should use __ARCH_HAS_MMU__ rather than 	__UCLIBC_HAS_MMU__
Date: Wed, 07 Mar 2007 19:04:00 -0000	[thread overview]
Message-ID: <1173294277.22513.1.camel@localhost.localdomain> (raw)
In-Reply-To: <45EE3DD7.80302@ringle.org>

On Tue, 2007-03-06 at 23:21 -0500, Jon Ringle wrote:
> Please see: http://sourceware.org/ml/gdb/2007-03/msg00099.html
> 
> Jon
> 
> plain text document attachment (gdbserver-ARCH_HAS_MMU.patch)
> Index: linux-low.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
> retrieving revision 1.53
> diff -u -r1.53 linux-low.c
> --- linux-low.c	26 Feb 2007 20:10:18 -0000	1.53
> +++ linux-low.c	7 Mar 2007 04:14:22 -0000
> @@ -42,6 +42,12 @@
>  # define PTRACE_SETSIGINFO 0x4203
>  #endif
>  
> +#ifdef __UCLIBC__
> +#if !(defined(__UCLIBC_HAS_MMU__) || defined(__ARCH_HAS_MMU__))
> +#define HAS_NOMMU
> +#endif
> +#endif

Shouldn't it be !defined(__ARCH_HAS_MMU__)?


And please remove the change below -- I'm sure it has
nothing to do with the one above.

> Index: server.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
> retrieving revision 1.48
> diff -u -r1.48 server.c
> --- server.c	26 Feb 2007 20:10:18 -0000	1.48
> +++ server.c	7 Mar 2007 04:14:23 -0000
> @@ -255,7 +255,7 @@
>  {
>    static struct inferior_list_entry *thread_ptr;
>  
> -  if (strcmp ("qSymbol::", own_buf) == 0)
> +  if (strcmp ("qSymbol:", own_buf) == 0)
>      {
>        if (the_target->look_up_symbols != NULL)
>  	(*the_target->look_up_symbols) ();


  parent reply	other threads:[~2007-03-07 19:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-07  4:21 Jon Ringle
2007-03-07 12:21 ` Daniel Jacobowitz
2007-03-07 13:12   ` [SPAM] " Jon Ringle
2007-03-07 19:11     ` Michael Snyder
2007-03-07 19:04 ` Michael Snyder [this message]
2007-03-27 18:32 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173294277.22513.1.camel@localhost.localdomain \
    --to=michael.snyder@palmsource.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jon@ringle.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox