From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7598 invoked by alias); 7 Mar 2007 19:04:52 -0000 Received: (qmail 7590 invoked by uid 22791); 7 Mar 2007 19:04:51 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.palmsource.com (HELO mx2.palmsource.com) (12.7.175.14) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 07 Mar 2007 19:04:41 +0000 Received: from localhost (localhost [127.0.0.1]) by localhost.domain.tld (Postfix) with ESMTP id 41190135FB0; Wed, 7 Mar 2007 11:04:40 -0800 (PST) Received: from mx2.palmsource.com ([127.0.0.1]) by localhost (mx2.palmsource.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 05816-08-2; Wed, 7 Mar 2007 11:04:39 -0800 (PST) Received: from ussunex01.palmsource.com (unknown [192.168.101.9]) by mx2.palmsource.com (Postfix) with ESMTP id 3428D135F91; Wed, 7 Mar 2007 11:04:39 -0800 (PST) Received: from 192.168.92.81 ([192.168.92.81]) by ussunex01.palmsource.com ([192.168.101.9]) via Exchange Front-End Server owa.palmsource.com ([10.0.20.17]) with Microsoft Exchange Server HTTP-DAV ; Wed, 7 Mar 2007 19:04:38 +0000 Received: from svmsnyderlnx by owa.palmsource.com; 07 Mar 2007 11:04:37 -0800 Subject: Re: gdbserver: should use __ARCH_HAS_MMU__ rather than __UCLIBC_HAS_MMU__ From: Michael Snyder To: Jon Ringle Cc: gdb-patches@sourceware.org In-Reply-To: <45EE3DD7.80302@ringle.org> References: <45EE3DD7.80302@ringle.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Wed, 07 Mar 2007 19:04:00 -0000 Message-Id: <1173294277.22513.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00076.txt.bz2 On Tue, 2007-03-06 at 23:21 -0500, Jon Ringle wrote: > Please see: http://sourceware.org/ml/gdb/2007-03/msg00099.html > > Jon > > plain text document attachment (gdbserver-ARCH_HAS_MMU.patch) > Index: linux-low.c > =================================================================== > RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v > retrieving revision 1.53 > diff -u -r1.53 linux-low.c > --- linux-low.c 26 Feb 2007 20:10:18 -0000 1.53 > +++ linux-low.c 7 Mar 2007 04:14:22 -0000 > @@ -42,6 +42,12 @@ > # define PTRACE_SETSIGINFO 0x4203 > #endif > > +#ifdef __UCLIBC__ > +#if !(defined(__UCLIBC_HAS_MMU__) || defined(__ARCH_HAS_MMU__)) > +#define HAS_NOMMU > +#endif > +#endif Shouldn't it be !defined(__ARCH_HAS_MMU__)? And please remove the change below -- I'm sure it has nothing to do with the one above. > Index: server.c > =================================================================== > RCS file: /cvs/src/src/gdb/gdbserver/server.c,v > retrieving revision 1.48 > diff -u -r1.48 server.c > --- server.c 26 Feb 2007 20:10:18 -0000 1.48 > +++ server.c 7 Mar 2007 04:14:23 -0000 > @@ -255,7 +255,7 @@ > { > static struct inferior_list_entry *thread_ptr; > > - if (strcmp ("qSymbol::", own_buf) == 0) > + if (strcmp ("qSymbol:", own_buf) == 0) > { > if (the_target->look_up_symbols != NULL) > (*the_target->look_up_symbols) ();