From: msnyder@sonic.net
To: "Joel Brobecker" <brobecker@adacore.com>
Cc: msnyder@sonic.net, gdb-patches@sourceware.org
Subject: Re: [patch] gnu-v2-abi.c: strchr may return null
Date: Wed, 05 Sep 2007 00:04:00 -0000 [thread overview]
Message-ID: <11647.12.7.175.2.1188950636.squirrel@webmail.sonic.net> (raw)
In-Reply-To: <20070904141830.GC3579@adacore.com>
>> 2007-08-29 Michael Snyder <msnyder@access-company.com>
>>
>> * gnu-v2-abi.c (gnuv2_value_rtti_type): Guard against null.
>
> This looks OK to me, but can you give it a few more days so that Daniel
> can provide any comment on it (C++ is not our main focus at AdaCore)?
On Daniel's subsequent approval (or acquiescence?), committing.
> I'm thinking this is perhaps a case where an assert might be better:
> Does the rest of the function make any sense if we don't find our
> space? I don't know the encoding so perhaps it's OK to give it a try...
Well, it won't make it any worse. If any reason manifests itself
to go with an assert, we can do that.
prev parent reply other threads:[~2007-09-05 0:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 21:26 msnyder
2007-09-04 14:18 ` Joel Brobecker
2007-09-04 14:20 ` Daniel Jacobowitz
2007-09-05 0:04 ` msnyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11647.12.7.175.2.1188950636.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox