From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50652-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2369 invoked by alias); 5 Sep 2007 00:04:11 -0000
Received: (qmail 2351 invoked by uid 22791); 5 Sep 2007 00:04:10 -0000
X-Spam-Check-By: sourceware.org
Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Sep 2007 00:04:01 +0000
Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) 	by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l8503uae006023; 	Tue, 4 Sep 2007 17:03:56 -0700
Received: from 12.7.175.2         (SquirrelMail authenticated user msnyder)         by webmail.sonic.net with HTTP;         Tue, 4 Sep 2007 17:03:56 -0700 (PDT)
Message-ID: <11647.12.7.175.2.1188950636.squirrel@webmail.sonic.net>
In-Reply-To: <20070904141830.GC3579@adacore.com>
References: <16934.12.7.175.2.1188422744.squirrel@webmail.sonic.net>     <20070904141830.GC3579@adacore.com>
Date: Wed, 05 Sep 2007 00:04:00 -0000
Subject: Re: [patch] gnu-v2-abi.c: strchr may return null
From: msnyder@sonic.net
To: "Joel Brobecker" <brobecker@adacore.com>
Cc: msnyder@sonic.net, gdb-patches@sourceware.org
User-Agent: SquirrelMail/1.4.9a
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-09/txt/msg00061.txt.bz2

>> 2007-08-29  Michael Snyder  <msnyder@access-company.com>
>>
>> 	* gnu-v2-abi.c (gnuv2_value_rtti_type): Guard against null.
>
> This looks OK to me, but can you give it a few more days so that Daniel
> can provide any comment on it (C++ is not our main focus at AdaCore)?

On Daniel's subsequent approval (or acquiescence?), committing.

> I'm thinking this is perhaps a case where an assert might be better:
> Does the rest of the function make any sense if we don't find our
> space? I don't know the encoding so perhaps it's OK to give it a try...

Well, it won't make it any worse.  If any reason manifests itself
to go with an assert, we can do that.