Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <Michael.Snyder@palmsource.com>
To: Maxim Grigoriev <maxim@tensilica.com>
Cc: gdb-patches@sources.redhat.com,
		Bob Wilson <bwilson@tensilica.com>,
		chris Zankel <zankel@tensilica.com>
Subject: Re: Xtensa port
Date: Fri, 22 Sep 2006 18:52:00 -0000	[thread overview]
Message-ID: <1158951165.22863.82.camel@localhost.localdomain> (raw)
In-Reply-To: <45142A88.7000805@hq.tensilica.com>

On Fri, 2006-09-22 at 11:25 -0700, Maxim Grigoriev wrote:
> DESCRIPTION:
> 
>     Basic Xtensa port. It doesn't include any targets. The next step will be
> a submission of "xtensa*-*-linux" target. It will include gdbserver port and
> everything else necessary to debug Xtensa code on this target.
> 
> If this port is accepted Tensilica commits to maintain GDB Xtensa support.

Maxim, 

At a quick first glance, it looks pretty good.
Do you have a copyright assignment on file?

One question -- is there a reason for splitting xtensa-config.c 
into a separate file?  Not necessarily a problem, but it seems
to be mostly stuff that would traditionally go in the xxx-tdep.c
file (such as the struct gdbarch_tdep object).

Thanks,
Michael Snyder


  reply	other threads:[~2006-09-22 18:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-22 18:25 Maxim Grigoriev
2006-09-22 18:52 ` Michael Snyder [this message]
2006-09-22 19:11   ` Maxim Grigoriev
2006-09-22 20:11     ` Michael Snyder
2006-09-22 21:48       ` Maxim Grigoriev
2006-09-22 23:53         ` Daniel Jacobowitz
2006-09-22 19:07 ` Daniel Jacobowitz
2006-09-22 19:39   ` Maxim Grigoriev
2006-09-22 20:32 ` Jim Blandy
2006-09-22 23:59   ` Maxim Grigoriev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1158951165.22863.82.camel@localhost.localdomain \
    --to=michael.snyder@palmsource.com \
    --cc=bwilson@tensilica.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=maxim@tensilica.com \
    --cc=zankel@tensilica.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox