From: Michael Snyder <Michael.Snyder@palmsource.com>
To: Ilko Iliev <office@ronetix.at>
Cc: gdb-patches@sourceware.org
Subject: Re: "Transfer rate" patch
Date: Tue, 05 Sep 2006 18:03:00 -0000 [thread overview]
Message-ID: <1157479424.9297.6.camel@localhost.localdomain> (raw)
In-Reply-To: <44FD2640.7080605@ronetix.at>
On Tue, 2006-09-05 at 09:24 +0200, Ilko Iliev wrote:
> Hi,
>
> I found a small bug by the calculating of the transfer rate at the
> "load" command - if the download image size or the download speed is
> higher then occurs overflow and the printed information is wrong.
>
> I attached a patch for this problem.
Thank you Ilko -- two requests.
1) The gnu coding standard calls for a white space on each side
of an operator, eg. not "(foo)*1000" but (foo) * 1000". Could
you add those please? If you need to break a long line, break
it at an operator, and put the operator on the new line. And,
2) All patches require a ChangeLog entry. It should be short
and descriptive, eg. "Fixed overflow problem". See the file,
ChangeLog, to get the format, and please include an entry when
you re-submit.
Thanks,
Michael Snyder
next prev parent reply other threads:[~2006-09-05 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 7:25 Ilko Iliev
2006-09-05 18:03 ` Michael Snyder [this message]
2006-09-06 7:11 ` Vladimir Prus
2006-09-07 14:20 ` Ilko Iliev
2006-09-07 14:58 ` Vladimir Prus
2006-09-07 19:54 ` Mark Kettenis
2006-09-10 18:50 ` Ilko Iliev
2006-10-17 16:04 ` Andrew STUBBS
2006-10-17 16:08 ` Daniel Jacobowitz
2006-09-07 14:44 ` Andrew STUBBS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157479424.9297.6.camel@localhost.localdomain \
--to=michael.snyder@palmsource.com \
--cc=gdb-patches@sourceware.org \
--cc=office@ronetix.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox