From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6058 invoked by alias); 5 Sep 2006 18:03:49 -0000 Received: (qmail 6049 invoked by uid 22791); 5 Sep 2006 18:03:48 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.palmsource.com (HELO mx2.palmsource.com) (12.7.175.14) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 05 Sep 2006 18:03:46 +0000 Received: from localhost (localhost [127.0.0.1]) by localhost.domain.tld (Postfix) with ESMTP id 5FF4825C44; Tue, 5 Sep 2006 11:03:45 -0700 (PDT) Received: from mx2.palmsource.com ([127.0.0.1]) by localhost (mx2.palmsource.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 14559-01-30; Tue, 5 Sep 2006 11:03:44 -0700 (PDT) Received: from ussunex01.palmsource.com (unknown [192.168.101.9]) by mx2.palmsource.com (Postfix) with ESMTP id 75DFE25BE0; Tue, 5 Sep 2006 11:03:44 -0700 (PDT) Received: from 192.168.92.59 ([192.168.92.59]) by ussunex01.palmsource.com ([192.168.101.9]) via Exchange Front-End Server owa.palmsource.com ([10.0.20.17]) with Microsoft Exchange Server HTTP-DAV ; Tue, 5 Sep 2006 18:03:44 +0000 Received: from svmsnyderlnx by owa.palmsource.com; 05 Sep 2006 11:03:44 -0700 Subject: Re: "Transfer rate" patch From: Michael Snyder To: Ilko Iliev Cc: gdb-patches@sourceware.org In-Reply-To: <44FD2640.7080605@ronetix.at> References: <44FD2640.7080605@ronetix.at> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 05 Sep 2006 18:03:00 -0000 Message-Id: <1157479424.9297.6.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00018.txt.bz2 On Tue, 2006-09-05 at 09:24 +0200, Ilko Iliev wrote: > Hi, > > I found a small bug by the calculating of the transfer rate at the > "load" command - if the download image size or the download speed is > higher then occurs overflow and the printed information is wrong. > > I attached a patch for this problem. Thank you Ilko -- two requests. 1) The gnu coding standard calls for a white space on each side of an operator, eg. not "(foo)*1000" but (foo) * 1000". Could you add those please? If you need to break a long line, break it at an operator, and put the operator on the new line. And, 2) All patches require a ChangeLog entry. It should be short and descriptive, eg. "Fixed overflow problem". See the file, ChangeLog, to get the format, and please include an entry when you re-submit. Thanks, Michael Snyder