Re: [patch] MIPS16e support in simulator.

[Eric Christopher <echristo@redhat.com>]

> > 
> > Looks like the jump instructions aren't executing the instructions in
> > the delay slot? See the definition of jalr in m16.igen.
> 
> This is correct.  The MIPS16e jrc, jalrc etc does not have a delay slot.
> 

OK. The docs I have don't call this out explicitly in the instruction
description and probably should given that other mips (and mips16)
instructions have delay slots.

> > 
> > I guess a good question would be asking how this patch was tested?
> > 
> > Otherwise it looks fine.
> 
> We've actually had MIPS16e simulator support for quite awhile at MIPS
> for our internal use.  We've been doing nightly regressions test on
> MIPS16e for gcc 3.4 and gdb for more that half year now.

You should say that sort of thing when you submit patches, e.g.:

"Tested on mips-elf using internal mips16e port. No regressions."

or some such.

-eric