From: Eric Christopher <echristo@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: David Ung <davidu@mips.com>,
binutils@sourceware.org, gdb-patches@sources.redhat.com
Subject: Re: [patch] MIPS16e support in simulator.
Date: Mon, 13 Jun 2005 23:22:00 -0000 [thread overview]
Message-ID: <1118704956.5119.68.camel@localhost.localdomain> (raw)
In-Reply-To: <20050613170353.GA19310@nevyn.them.org>
On Mon, 2005-06-13 at 13:03 -0400, Daniel Jacobowitz wrote:
> On Mon, Jun 13, 2005 at 10:02:45AM -0700, Eric Christopher wrote:
> >
> > > So um... unfortunately, GDB does not have an active MIPS maintainer at
> > > the moment. I do not see anything (other than your followup about the
> > > mipsisa32 configure stanza) obviously wrong with these changes, but I
> > > can't provide any useful review of the mips-specific bits. I don't
> > > suppose someone on binutils@ could lend a hand?
> > >
> >
> > I will, url to the original patch?
>
> http://sourceware.org/ml/gdb-patches/2005-06/msg00078.html
> http://sourceware.org/ml/gdb-patches/2005-06/msg00079.html
Looks like the jump instructions aren't executing the instructions in
the delay slot? See the definition of jalr in m16.igen.
I guess a good question would be asking how this patch was tested?
Otherwise it looks fine.
-eric
next prev parent reply other threads:[~2005-06-13 23:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-09 16:52 David Ung
2005-06-09 16:59 ` David Ung
2005-06-13 3:18 ` Daniel Jacobowitz
2005-06-13 17:03 ` Eric Christopher
2005-06-13 17:04 ` Daniel Jacobowitz
2005-06-13 23:22 ` Eric Christopher [this message]
2005-06-14 11:09 ` David Ung
2005-06-14 17:40 ` Eric Christopher
2005-06-14 17:51 ` Maciej W. Rozycki
2005-06-14 18:08 ` Eric Christopher
2005-06-14 17:48 ` Daniel Jacobowitz
2005-06-15 11:42 ` David Ung
2005-06-15 16:12 ` Andrew Cagney
2005-06-16 15:19 ` David Ung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118704956.5119.68.camel@localhost.localdomain \
--to=echristo@redhat.com \
--cc=binutils@sourceware.org \
--cc=davidu@mips.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox