Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFC/readline] bind.c, rl_function_dumper,  Free allocated memory.
@ 2011-03-03 22:38 Michael Snyder
  2011-03-04  2:35 ` Tom Tromey
  2011-03-04 16:12 ` [Bug-readline] " Chet Ramey
  0 siblings, 2 replies; 4+ messages in thread
From: Michael Snyder @ 2011-03-03 22:38 UTC (permalink / raw)
  To: gdb-patches, bug-readline

[-- Attachment #1: Type: text/plain, Size: 5 bytes --]

OK?


[-- Attachment #2: bind.txt --]
[-- Type: text/plain, Size: 521 bytes --]

2011-03-03  Michael Snyder  <msnyder@vmware.com>

	* bind.c (rl_function_dumper): Free allocated memory.

Index: bind.c
===================================================================
RCS file: /cvs/src/src/readline/bind.c,v
retrieving revision 1.8
diff -u -p -u -p -r1.8 bind.c
--- bind.c	5 May 2006 18:26:12 -0000	1.8
+++ bind.c	3 Mar 2011 22:20:14 -0000
@@ -2068,6 +2068,7 @@ rl_function_dumper (print_readably)
 	    }
 	}
     }
+  free (names);
 }
 
 /* Print all of the current functions and their bindings to

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFC/readline] bind.c, rl_function_dumper,  Free allocated memory.
  2011-03-03 22:38 [RFC/readline] bind.c, rl_function_dumper, Free allocated memory Michael Snyder
@ 2011-03-04  2:35 ` Tom Tromey
  2011-03-04 16:12 ` [Bug-readline] " Chet Ramey
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Tromey @ 2011-03-04  2:35 UTC (permalink / raw)
  To: Michael Snyder; +Cc: gdb-patches, bug-readline

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> 2011-03-03  Michael Snyder  <msnyder@vmware.com>
Michael> 	* bind.c (rl_function_dumper): Free allocated memory.

It is probably worth mentioning that src/ still has an ancient version
of readline.  I think nobody has imported a new version since 5.1.

Tom


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Bug-readline] [RFC/readline] bind.c, rl_function_dumper, Free allocated memory.
  2011-03-03 22:38 [RFC/readline] bind.c, rl_function_dumper, Free allocated memory Michael Snyder
  2011-03-04  2:35 ` Tom Tromey
@ 2011-03-04 16:12 ` Chet Ramey
  2011-03-04 18:13   ` Michael Snyder
  1 sibling, 1 reply; 4+ messages in thread
From: Chet Ramey @ 2011-03-04 16:12 UTC (permalink / raw)
  To: msnyder; +Cc: gdb-patches, bug-readline, chet

> OK?

Looks good to me.

-- 
``The lyf so short, the craft so long to lerne.'' - Chaucer
		 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU    chet@case.edu    http://cnswww.cns.cwru.edu/~chet/


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Bug-readline] [RFC/readline] bind.c, rl_function_dumper, Free allocated memory.
  2011-03-04 16:12 ` [Bug-readline] " Chet Ramey
@ 2011-03-04 18:13   ` Michael Snyder
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Snyder @ 2011-03-04 18:13 UTC (permalink / raw)
  To: chet.ramey; +Cc: gdb-patches, bug-readline, chet

Chet Ramey wrote:
>> OK?
> 
> Looks good to me.
> 

Thanks, committed in 'src' version.

Michael



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-03-04 18:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-03 22:38 [RFC/readline] bind.c, rl_function_dumper, Free allocated memory Michael Snyder
2011-03-04  2:35 ` Tom Tromey
2011-03-04 16:12 ` [Bug-readline] " Chet Ramey
2011-03-04 18:13   ` Michael Snyder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox