* Patch: fix monitor.c build problem
@ 2003-09-22 14:28 Anthony Green
2003-09-22 14:44 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Green @ 2003-09-22 14:28 UTC (permalink / raw)
To: gdb-patches
I am unable to build monitor.c with a recent gcc because of a
conflicting targ_ops declaration (both static and extern in same
compilation unit). It looks like we can just delete the second
declaration. Ok?
2003-09-22 Anthony Green <green@redhat.com>
* monitor.c (monitor_expect): Delete unused conflicting targ_ops
declaration.
Index: gdb/monitor.c
===================================================================
RCS file: /cvs/uberbaum/gdb/monitor.c,v
retrieving revision 1.42
diff -c -u -p -r1.42 monitor.c
--- gdb/monitor.c 11 Jun 2003 13:16:28 -0000 1.42
+++ gdb/monitor.c 22 Sep 2003 14:23:57 -0000
@@ -521,7 +521,6 @@ monitor_expect (char *string, char *buf,
char *p = string;
int obuflen = buflen;
int c;
- extern struct target_ops *targ_ops;
if (monitor_debug_p)
{
--
Anthony Green <green@redhat.com>
Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch: fix monitor.c build problem
2003-09-22 14:28 Patch: fix monitor.c build problem Anthony Green
@ 2003-09-22 14:44 ` Daniel Jacobowitz
2003-09-22 14:56 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2003-09-22 14:44 UTC (permalink / raw)
To: Anthony Green; +Cc: gdb-patches
On Mon, Sep 22, 2003 at 07:28:53AM -0700, Anthony Green wrote:
> I am unable to build monitor.c with a recent gcc because of a
> conflicting targ_ops declaration (both static and extern in same
> compilation unit). It looks like we can just delete the second
> declaration. Ok?
Sure.
> 2003-09-22 Anthony Green <green@redhat.com>
>
> * monitor.c (monitor_expect): Delete unused conflicting targ_ops
> declaration.
>
>
> Index: gdb/monitor.c
> ===================================================================
> RCS file: /cvs/uberbaum/gdb/monitor.c,v
> retrieving revision 1.42
> diff -c -u -p -r1.42 monitor.c
> --- gdb/monitor.c 11 Jun 2003 13:16:28 -0000 1.42
> +++ gdb/monitor.c 22 Sep 2003 14:23:57 -0000
> @@ -521,7 +521,6 @@ monitor_expect (char *string, char *buf,
> char *p = string;
> int obuflen = buflen;
> int c;
> - extern struct target_ops *targ_ops;
>
> if (monitor_debug_p)
> {
>
>
> --
> Anthony Green <green@redhat.com>
> Red Hat, Inc.
>
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Patch: fix monitor.c build problem
2003-09-22 14:44 ` Daniel Jacobowitz
@ 2003-09-22 14:56 ` Andrew Cagney
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2003-09-22 14:56 UTC (permalink / raw)
To: Daniel Jacobowitz, Anthony Green; +Cc: gdb-patches
> On Mon, Sep 22, 2003 at 07:28:53AM -0700, Anthony Green wrote:
>
>> I am unable to build monitor.c with a recent gcc because of a
>> conflicting targ_ops declaration (both static and extern in same
>> compilation unit). It looks like we can just delete the second
>> declaration. Ok?
>
>
> Sure.
Stronger, "obvious". There are too many of the [au explitive] lurking
in .c files.
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-09-22 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-22 14:28 Patch: fix monitor.c build problem Anthony Green
2003-09-22 14:44 ` Daniel Jacobowitz
2003-09-22 14:56 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox