Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: "gdb-patches@sources.redhat.com" <gdb-patches@sources.redhat.com>,
	Andrew Cagney <ac131313@redhat.com>
Subject: Re: [rfa] missing frame_register
Date: Mon, 17 Mar 2003 20:56:00 -0000	[thread overview]
Message-ID: <1047935045.1490.50.camel@lindt.uglyboxes.com> (raw)
In-Reply-To: <ro11y15g4he.fsf@jackfruit.Stanford.EDU>

On Mon, 2003-03-17 at 11:47, David Carlton wrote:

I was hoping not to have to do anything about this until later (let 'em
sweat for a few hours! :v), but I don't believe the below will work: 

> +    frame_register (deprecated_selected_frame, regnum, &optim,
> +		    NULL, NULL, &realnum, raw_buffer);

In frame.c:

void
frame_register (struct frame_info *frame, int regnum,
                int *optimizedp, enum lval_type *lvalp,
                CORE_ADDR *addrp, int *realnump, void *bufferp)
{
  /* Require all but BUFFERP to be valid.  A NULL BUFFERP indicates
     that the value proper does not need to be fetched.  */
  gdb_assert (optimizedp != NULL);
  gdb_assert (lvalp != NULL);
  gdb_assert (addrp != NULL);
  gdb_assert (realnump != NULL);
  /* gdb_assert (bufferp != NULL); */

I have a patch that does work (I think), and I will check it in
momentarily, unless you want to follow through. I've done exactly the
same as you, expect I called frame_reigster with no NULL values. Six of
one, half-dozen of the other, I think.

I'll check mine in if I don't see a commit from you. I appreciate your
thinking of me, urgh, insight!

Keith





  reply	other threads:[~2003-03-17 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-17 19:47 David Carlton
2003-03-17 20:56 ` Keith Seitz [this message]
2003-03-17 21:05   ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1047935045.1490.50.camel@lindt.uglyboxes.com \
    --to=keiths@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=carlton@math.stanford.edu \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox