From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30880 invoked by alias); 17 Mar 2003 20:56:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30802 invoked from network); 17 Mar 2003 20:56:16 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 17 Mar 2003 20:56:16 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h2HKuGQ01890 for ; Mon, 17 Mar 2003 15:56:16 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h2HKuFV23453; Mon, 17 Mar 2003 15:56:15 -0500 Received: from [150.1.200.14] (vpn50-9.rdu.redhat.com [172.16.50.9]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h2HKuEL07057; Mon, 17 Mar 2003 15:56:14 -0500 Subject: Re: [rfa] missing frame_register From: Keith Seitz To: David Carlton Cc: "gdb-patches@sources.redhat.com" , Andrew Cagney In-Reply-To: References: Content-Type: text/plain Organization: Message-Id: <1047935045.1490.50.camel@lindt.uglyboxes.com> Mime-Version: 1.0 Date: Mon, 17 Mar 2003 20:56:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00379.txt.bz2 On Mon, 2003-03-17 at 11:47, David Carlton wrote: I was hoping not to have to do anything about this until later (let 'em sweat for a few hours! :v), but I don't believe the below will work: > + frame_register (deprecated_selected_frame, regnum, &optim, > + NULL, NULL, &realnum, raw_buffer); In frame.c: void frame_register (struct frame_info *frame, int regnum, int *optimizedp, enum lval_type *lvalp, CORE_ADDR *addrp, int *realnump, void *bufferp) { /* Require all but BUFFERP to be valid. A NULL BUFFERP indicates that the value proper does not need to be fetched. */ gdb_assert (optimizedp != NULL); gdb_assert (lvalp != NULL); gdb_assert (addrp != NULL); gdb_assert (realnump != NULL); /* gdb_assert (bufferp != NULL); */ I have a patch that does work (I think), and I will check it in momentarily, unless you want to follow through. I've done exactly the same as you, expect I called frame_reigster with no NULL values. Six of one, half-dozen of the other, I think. I'll check mine in if I don't see a commit from you. I appreciate your thinking of me, urgh, insight! Keith