From: msnyder@sonic.net
To: "Jim Blandy" <jimb@codesourcery.com>
Cc: msnyder@sonic.net, gdb-patches@sourceware.org
Subject: Re: [patch] jv-lang.c, dead code
Date: Wed, 08 Aug 2007 18:48:00 -0000 [thread overview]
Message-ID: <10421.12.7.175.2.1186598913.squirrel@webmail.sonic.net> (raw)
In-Reply-To: <m3hcnc477o.fsf@codesourcery.com>
>
> msnyder@sonic.net writes:
>> noside is tested twice.
>
> I'd agree that the code is messed up, and that your patch doesn't
> change its behavior, but which test is the one that ought to be there?
> I don't even know when EVAL_SKIP would be used for Java.
In that, I would have to defer to you.
Annotate says that all four instances of EVAL_SKIP in jv-lang.c
have been there from the beginning (1999).
The only other places where it occurs are in eval.c and ada-lang.c.
I would bet that the instances in jv-lang.c were copied from
a common ancestor with the bits in eval.c. The OP_STRING case,
for instance, looks like a close cousin.
next prev parent reply other threads:[~2007-08-08 18:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 4:09 msnyder
2007-08-06 22:41 ` Jim Blandy
2007-08-08 18:48 ` msnyder [this message]
2007-08-13 23:13 ` msnyder
2007-08-14 16:53 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10421.12.7.175.2.1186598913.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox