From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29844 invoked by alias); 8 Aug 2007 18:48:42 -0000 Received: (qmail 29803 invoked by uid 22791); 8 Aug 2007 18:48:41 -0000 X-Spam-Check-By: sourceware.org Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Aug 2007 18:48:39 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l78ImXI7014441; Wed, 8 Aug 2007 11:48:34 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Wed, 8 Aug 2007 11:48:33 -0700 (PDT) Message-ID: <10421.12.7.175.2.1186598913.squirrel@webmail.sonic.net> In-Reply-To: References: <21135.12.7.175.2.1186286956.squirrel@webmail.sonic.net> Date: Wed, 08 Aug 2007 18:48:00 -0000 Subject: Re: [patch] jv-lang.c, dead code From: msnyder@sonic.net To: "Jim Blandy" Cc: msnyder@sonic.net, gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00156.txt.bz2 > > msnyder@sonic.net writes: >> noside is tested twice. > > I'd agree that the code is messed up, and that your patch doesn't > change its behavior, but which test is the one that ought to be there? > I don't even know when EVAL_SKIP would be used for Java. In that, I would have to defer to you. Annotate says that all four instances of EVAL_SKIP in jv-lang.c have been there from the beginning (1999). The only other places where it occurs are in eval.c and ada-lang.c. I would bet that the instances in jv-lang.c were copied from a common ancestor with the bits in eval.c. The OP_STRING case, for instance, looks like a close cousin.