From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 1 of 4
Date: Mon, 13 Oct 2003 23:43:00 -0000 [thread overview]
Message-ID: <1031013234253.ZM23281@localhost.localdomain> (raw)
In-Reply-To: Kevin Buettner <kevinb@redhat.com> "[RFC] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 1 of 4" (Oct 3, 5:28pm)
On Oct 3, 5:28pm, Kevin Buettner wrote:
> * arch-utils.h (default_target_adjust_breakpoint_address): New
> function declaration.
> * arch-utils.c (default_target_adjust_breakpoint_address): New
> function.
> * gdbarch.sh (TARGET_ADJUST_BREAKPOINT_ADDRESS): New method.
> * gdbarch.h, gdbarch.c: Regenerate.
I reworked this patch per Andrew's and Mark's suggestions. Using an
"M" (method with predicate) eliminated the need for the
arch-utils.[hc] changes.
Here's what I've checked in:
* gdbarch.sh (ADJUST_BREAKPOINT_ADDRESS): New method.
* gdbarch.h, gdbarch.c: Regenerate.
Index: gdbarch.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdbarch.sh,v
retrieving revision 1.277
diff -u -p -r1.277 gdbarch.sh
--- gdbarch.sh 11 Oct 2003 12:52:29 -0000 1.277
+++ gdbarch.sh 13 Oct 2003 23:33:27 -0000
@@ -614,6 +614,7 @@ f:2:SKIP_PROLOGUE:CORE_ADDR:skip_prologu
f:2:PROLOGUE_FRAMELESS_P:int:prologue_frameless_p:CORE_ADDR ip:ip::0:generic_prologue_frameless_p::0
f:2:INNER_THAN:int:inner_than:CORE_ADDR lhs, CORE_ADDR rhs:lhs, rhs::0:0
f::BREAKPOINT_FROM_PC:const unsigned char *:breakpoint_from_pc:CORE_ADDR *pcptr, int *lenptr:pcptr, lenptr:::0:
+M:2:ADJUST_BREAKPOINT_ADDRESS:CORE_ADDR:adjust_breakpoint_address:CORE_ADDR bpaddr:bpaddr
f:2:MEMORY_INSERT_BREAKPOINT:int:memory_insert_breakpoint:CORE_ADDR addr, char *contents_cache:addr, contents_cache::0:default_memory_insert_breakpoint::0
f:2:MEMORY_REMOVE_BREAKPOINT:int:memory_remove_breakpoint:CORE_ADDR addr, char *contents_cache:addr, contents_cache::0:default_memory_remove_breakpoint::0
v:2:DECR_PC_AFTER_BREAK:CORE_ADDR:decr_pc_after_break::::0:-1
prev parent reply other threads:[~2003-10-13 23:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-04 0:28 Kevin Buettner
2003-10-06 12:49 ` Mark Kettenis
2003-10-06 14:37 ` Andrew Cagney
2003-10-06 15:37 ` Kevin Buettner
2003-10-06 21:09 ` Mark Kettenis
2003-10-08 18:26 ` Andrew Cagney
2003-10-11 2:17 ` Kevin Buettner
2003-10-11 16:17 ` Andrew Cagney
2003-10-13 23:43 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1031013234253.ZM23281@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox