From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23774 invoked by alias); 13 Oct 2003 23:43:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23766 invoked from network); 13 Oct 2003 23:43:02 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 13 Oct 2003 23:43:02 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9DNgxM29125 for ; Mon, 13 Oct 2003 19:42:59 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9DNgxr05516 for ; Mon, 13 Oct 2003 19:42:59 -0400 Received: from localhost.localdomain (vpn50-39.rdu.redhat.com [172.16.50.39]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9DNgw6x019407; Mon, 13 Oct 2003 19:42:59 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h9DNgrX23282; Mon, 13 Oct 2003 16:42:53 -0700 Date: Mon, 13 Oct 2003 23:43:00 -0000 From: Kevin Buettner Message-Id: <1031013234253.ZM23281@localhost.localdomain> In-Reply-To: Kevin Buettner "[RFC] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 1 of 4" (Oct 3, 5:28pm) References: <1031004002813.ZM24546@localhost.localdomain> To: gdb-patches@sources.redhat.com Subject: Re: [RFC] TARGET_ADJUST_BREAKPOINT_ADDRESS - patch 1 of 4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00433.txt.bz2 On Oct 3, 5:28pm, Kevin Buettner wrote: > * arch-utils.h (default_target_adjust_breakpoint_address): New > function declaration. > * arch-utils.c (default_target_adjust_breakpoint_address): New > function. > * gdbarch.sh (TARGET_ADJUST_BREAKPOINT_ADDRESS): New method. > * gdbarch.h, gdbarch.c: Regenerate. I reworked this patch per Andrew's and Mark's suggestions. Using an "M" (method with predicate) eliminated the need for the arch-utils.[hc] changes. Here's what I've checked in: * gdbarch.sh (ADJUST_BREAKPOINT_ADDRESS): New method. * gdbarch.h, gdbarch.c: Regenerate. Index: gdbarch.sh =================================================================== RCS file: /cvs/src/src/gdb/gdbarch.sh,v retrieving revision 1.277 diff -u -p -r1.277 gdbarch.sh --- gdbarch.sh 11 Oct 2003 12:52:29 -0000 1.277 +++ gdbarch.sh 13 Oct 2003 23:33:27 -0000 @@ -614,6 +614,7 @@ f:2:SKIP_PROLOGUE:CORE_ADDR:skip_prologu f:2:PROLOGUE_FRAMELESS_P:int:prologue_frameless_p:CORE_ADDR ip:ip::0:generic_prologue_frameless_p::0 f:2:INNER_THAN:int:inner_than:CORE_ADDR lhs, CORE_ADDR rhs:lhs, rhs::0:0 f::BREAKPOINT_FROM_PC:const unsigned char *:breakpoint_from_pc:CORE_ADDR *pcptr, int *lenptr:pcptr, lenptr:::0: +M:2:ADJUST_BREAKPOINT_ADDRESS:CORE_ADDR:adjust_breakpoint_address:CORE_ADDR bpaddr:bpaddr f:2:MEMORY_INSERT_BREAKPOINT:int:memory_insert_breakpoint:CORE_ADDR addr, char *contents_cache:addr, contents_cache::0:default_memory_insert_breakpoint::0 f:2:MEMORY_REMOVE_BREAKPOINT:int:memory_remove_breakpoint:CORE_ADDR addr, char *contents_cache:addr, contents_cache::0:default_memory_remove_breakpoint::0 v:2:DECR_PC_AFTER_BREAK:CORE_ADDR:decr_pc_after_break::::0:-1