From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [rfa] Fix ppc32 GNU/Linux (and AIX) struct convention
Date: Tue, 16 Sep 2003 20:20:00 -0000 [thread overview]
Message-ID: <1030916201952.ZM6365@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "[rfa] Fix ppc32 GNU/Linux (and AIX) struct convention" (Sep 13, 5:57pm)
On Sep 13, 5:57pm, Andrew Cagney wrote:
> * ppc-linux-tdep.c (ppc_linux_init_abi): Set the 32 bit
> "use_struct_convention" to "rs6000_use_struct_convention".
> * ppc-tdep.h (rs6000_use_struct_convention): Declare.
No. I would prefer that ppc-linux-tdep.c contain its own (suitably
named) "use_struct_convention" code even if it's identical to the code
needed by AIX. That way we can tweak one without having to worry
about breaking the other.
> * rs6000-tdep.c (rs6000_use_struct_convention): New function.
> (rs6000_gdbarch_init): For AIX, set "use_struct_convention" to
> "rs6000_use_struct_convention".
Okay.
> * ppc-sysv-tdep.c (ppc_sysv_abi_broken_use_struct_convention):
> Delete function.
> * ppc-tdep.h (ppc_sysv_abi_broken_use_struct_convention): Delete.
Okay.
Kevin
next prev parent reply other threads:[~2003-09-16 20:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-13 21:57 Andrew Cagney
2003-09-16 20:20 ` Kevin Buettner [this message]
2003-09-16 23:34 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030916201952.ZM6365@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox