From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24073 invoked by alias); 16 Sep 2003 20:20:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24055 invoked from network); 16 Sep 2003 20:20:00 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 16 Sep 2003 20:20:00 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h8GKJx415319 for ; Tue, 16 Sep 2003 16:19:59 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h8GKJwe21279 for ; Tue, 16 Sep 2003 16:19:58 -0400 Received: from localhost.localdomain (vpn50-5.rdu.redhat.com [172.16.50.5]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h8GKJwxI026976; Tue, 16 Sep 2003 16:19:58 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h8GKJqZ06366; Tue, 16 Sep 2003 13:19:52 -0700 Date: Tue, 16 Sep 2003 20:20:00 -0000 From: Kevin Buettner Message-Id: <1030916201952.ZM6365@localhost.localdomain> In-Reply-To: Andrew Cagney "[rfa] Fix ppc32 GNU/Linux (and AIX) struct convention" (Sep 13, 5:57pm) References: <3F6392D5.30809@redhat.com> To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [rfa] Fix ppc32 GNU/Linux (and AIX) struct convention MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-09/txt/msg00364.txt.bz2 On Sep 13, 5:57pm, Andrew Cagney wrote: > * ppc-linux-tdep.c (ppc_linux_init_abi): Set the 32 bit > "use_struct_convention" to "rs6000_use_struct_convention". > * ppc-tdep.h (rs6000_use_struct_convention): Declare. No. I would prefer that ppc-linux-tdep.c contain its own (suitably named) "use_struct_convention" code even if it's identical to the code needed by AIX. That way we can tweak one without having to worry about breaking the other. > * rs6000-tdep.c (rs6000_use_struct_convention): New function. > (rs6000_gdbarch_init): For AIX, set "use_struct_convention" to > "rs6000_use_struct_convention". Okay. > * ppc-sysv-tdep.c (ppc_sysv_abi_broken_use_struct_convention): > Delete function. > * ppc-tdep.h (ppc_sysv_abi_broken_use_struct_convention): Delete. Okay. Kevin