From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>,
Jason Thorpe <thorpej@wasabisystems.com>
Cc: Daniel Jacobowitz <drow@mvista.com>,
"Nathan J. Williams" <nathanw@wasabisystems.com>,
gdb-patches@sources.redhat.com
Subject: Re: [PATCH] IBM6000_TARGET is wrong for NetBSD/powerpc
Date: Thu, 28 Aug 2003 19:54:00 -0000 [thread overview]
Message-ID: <1030828195354.ZM18258@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "Re: [PATCH] IBM6000_TARGET is wrong for NetBSD/powerpc" (Aug 28, 12:44pm)
On Aug 28, 12:44pm, Andrew Cagney wrote:
> > I agree, but we're talking about a simple bug-fix for an existing target, where the multi-arch-correct solution is not all that clear, because...
> >
> > - re-arange tm-rs6000.h so that the define wasn't needed
> > - move the define to nm-rs6000.h (sick but effective :-)
> >
> > ...it's an MI part of the debugger that is testing the define. How would you suggest modifying tm-rs6000.h to deal with this?
>
> Create an aix specific tm-rs6000.h, move the define to there and then
> kill the #undef's. Given that this macro will be deleted rather than
> multi-arched, moving [burrying] it to nm-rs6000.h (and zapping the
> #undefine is easier).
I agree that moving it to nm-rs6000.h is the way to go. I'm not terribly
worried about cross-debugging scenarios with AIX as the target since
I'm pretty sure that it never worked anyway.
I just took a look at the places where IBM6000_TARGET are used. This
code is _really_ ugly. E.g, anything vmap related in exec.c ought to
be moved somewhere else, maybe xcoffsolib.c.
Kevin
next prev parent reply other threads:[~2003-08-28 19:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-14 22:13 Nathan J. Williams
2003-08-28 14:24 ` Daniel Jacobowitz
2003-08-28 14:38 ` Jason Thorpe
2003-08-28 14:44 ` Daniel Jacobowitz
2003-08-28 15:39 ` Andrew Cagney
2003-08-28 16:10 ` Jason Thorpe
2003-08-28 16:44 ` Andrew Cagney
2003-08-28 19:54 ` Kevin Buettner [this message]
2003-09-03 20:17 ` Deprecate IBM6000_TARGET; Was: " Andrew Cagney
2003-09-03 20:25 ` Kevin Buettner
2003-09-03 20:57 ` Andrew Cagney
2003-09-03 21:15 ` Jason Thorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030828195354.ZM18258@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=nathanw@wasabisystems.com \
--cc=thorpej@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox