From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27666 invoked by alias); 28 Aug 2003 19:54:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27495 invoked from network); 28 Aug 2003 19:54:06 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 28 Aug 2003 19:54:06 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h7SJs6l18845 for ; Thu, 28 Aug 2003 15:54:06 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h7SJs6s10382; Thu, 28 Aug 2003 15:54:06 -0400 Received: from localhost.localdomain (vpn50-21.rdu.redhat.com [172.16.50.21]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h7SJs4No022848; Thu, 28 Aug 2003 15:54:05 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h7SJrtJ18259; Thu, 28 Aug 2003 12:53:55 -0700 Date: Thu, 28 Aug 2003 19:54:00 -0000 From: Kevin Buettner Message-Id: <1030828195354.ZM18258@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [PATCH] IBM6000_TARGET is wrong for NetBSD/powerpc" (Aug 28, 12:44pm) References: <1BD6D35A-D972-11D7-BD43-000A957650EC@wasabisystems.com> <3F4E3168.9060908@redhat.com> To: Andrew Cagney , Jason Thorpe Subject: Re: [PATCH] IBM6000_TARGET is wrong for NetBSD/powerpc Cc: Daniel Jacobowitz , "Nathan J. Williams" , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-08/txt/msg00517.txt.bz2 On Aug 28, 12:44pm, Andrew Cagney wrote: > > I agree, but we're talking about a simple bug-fix for an existing target, where the multi-arch-correct solution is not all that clear, because... > > > > - re-arange tm-rs6000.h so that the define wasn't needed > > - move the define to nm-rs6000.h (sick but effective :-) > > > > ...it's an MI part of the debugger that is testing the define. How would you suggest modifying tm-rs6000.h to deal with this? > > Create an aix specific tm-rs6000.h, move the define to there and then > kill the #undef's. Given that this macro will be deleted rather than > multi-arched, moving [burrying] it to nm-rs6000.h (and zapping the > #undefine is easier). I agree that moving it to nm-rs6000.h is the way to go. I'm not terribly worried about cross-debugging scenarios with AIX as the target since I'm pretty sure that it never worked anyway. I just took a look at the places where IBM6000_TARGET are used. This code is _really_ ugly. E.g, anything vmap related in exec.c ought to be moved somewhere else, maybe xcoffsolib.c. Kevin