small configuration patch to add xscale-linux support

small configuration patch to add xscale-linux support

[Brendan Conoboy]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

This patch allows one to configure an xscale-linux-gnu gdb (which is 
essentially the same thing as arm-linux-gnu for gdb, but not for other 
tools).  Works for me.

-Brendan (blc@redhat.com)

[-- Attachment #2: xscale-linux-config.patch --]
[-- Type: text/plain, Size: 1484 bytes --]

ChangeLog:
Mon Jul 21 20:10:16 UTC 2003  Brendan Conoboy  <blc@redhat.com>

        configure.host: Set gdb_host_cpu=arm when host_cpu=xscale

gdbserver/ChangeLog:
Mon Jul 21 20:09:34 UTC 2003  Brendan Conoboy  <blc@redhat.com>

        configure.srv: Add xscale*linux copy of arm*linux entry.

Index: configure.host
===================================================================
RCS file: /cvs/src/src/gdb/configure.host,v
retrieving revision 1.55
diff -c -r1.55 configure.host
*** configure.host	13 Jul 2003 16:15:59 -0000	1.55
--- configure.host	23 Jul 2003 17:46:21 -0000
***************
*** 21,26 ****
--- 21,27 ----
  s390*)			gdb_host_cpu=s390 ;;
  sh*)			gdb_host_cpu=sh ;;
  x86_64*)		gdb_host_cpu=i386 ;;
+ xscale*)		gdb_host_cpu=arm ;;
  *)			gdb_host_cpu=$host_cpu ;;
  
  esac
Index: gdbserver/configure.srv
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/configure.srv,v
retrieving revision 1.6
diff -c -r1.6 configure.srv
*** gdbserver/configure.srv	13 Jun 2003 17:49:52 -0000	1.6
--- gdbserver/configure.srv	23 Jul 2003 17:46:21 -0000
***************
*** 64,69 ****
--- 64,74 ----
  			srv_tgtobj="linux-low.o linux-x86-64-low.o i387-fp.o"
  			srv_linux_regsets=yes
  			;;
+   xscale*-*-linux*)	srv_regobj=reg-arm.o
+ 			srv_tgtobj="linux-low.o linux-arm-low.o"
+ 			srv_linux_usrregs=yes
+ 			srv_linux_thread_db=yes
+ 			;;
    *)			echo "Error: target not supported by gdbserver."
  			exit 1
  			;;

Re: small configuration patch to add xscale-linux support

[Kevin Buettner]

On Jul 23, 12:23pm, Brendan Conoboy wrote:

> This patch allows one to configure an xscale-linux-gnu gdb (which is 
> essentially the same thing as arm-linux-gnu for gdb, but not for other 
> tools).  Works for me.

Brendan's patch looks good to me, so I recommend that he be added to
the "Write After Approval" list.

Brendan, assuming that no one disagrees, I believe the next step is
for you to add yourself to the the "Write After Approval" list in
gdb/MAINTAINERS (with an appropriate entry added to gdb/ChangeLog as
well), commit it, and then post that patch to gdb-patches.

Then, assuming that there are no objections to your xscale config
patch, you can commit that.  I'd wait a couple of days for comments.

Kevin

Re: small configuration patch to add xscale-linux support

[Andrew Cagney]

> On Jul 23, 12:23pm, Brendan Conoboy wrote:
> 
> 
>> This patch allows one to configure an xscale-linux-gnu gdb (which is 
>> essentially the same thing as arm-linux-gnu for gdb, but not for other 
>> tools).  Works for me.
> 
> 
> Brendan's patch looks good to me, so I recommend that he be added to
> the "Write After Approval" list.

FYI, the recommendation is normally sent my way.  I'll see about an account.

Andrew

Re: small configuration patch to add xscale-linux support

[Brendan Conoboy]

Kevin Buettner wrote:
> Brendan's patch looks good to me, so I recommend that he be added to
> the "Write After Approval" list.

Woo!

> Brendan, assuming that no one disagrees, I believe the next step is
> for you to add yourself to the the "Write After Approval" list in
> gdb/MAINTAINERS (with an appropriate entry added to gdb/ChangeLog as
> well), commit it, and then post that patch to gdb-patches.

Done.

> Then, assuming that there are no objections to your xscale config
> patch, you can commit that.  I'd wait a couple of days for comments.

Andrew and yourself were the only respondents, so I've just committed 
these two patches.

-Brendan (blc@redhat.com)

Re: small configuration patch to add xscale-linux support

[Richard Earnshaw]

> This patch allows one to configure an xscale-linux-gnu gdb (which is 
> essentially the same thing as arm-linux-gnu for gdb, but not for other 
> tools).  Works for me.
> 
> -Brendan (blc@redhat.com)
> 
> ChangeLog:
> Mon Jul 21 20:10:16 UTC 2003  Brendan Conoboy  <blc@redhat.com>
> 
>         configure.host: Set gdb_host_cpu=arm when host_cpu=xscale
> 
> gdbserver/ChangeLog:
> Mon Jul 21 20:09:34 UTC 2003  Brendan Conoboy  <blc@redhat.com>
> 
>         configure.srv: Add xscale*linux copy of arm*linux entry.

Rather than copy the entry, I think you should just add an extra 
alternative to the existing entry:

-  arm*-*-linux*)        srv_regobj=reg-arm.o
+  arm*-*-linux* | xscale*-*-linux*)        srv_regobj=reg-arm.o

That keeps things more maintainable if the list of files ever change.


R.