Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Fix asm-source.exp for ppc
@ 2003-07-13  9:13 Andreas Schwab
  2003-07-18 14:10 ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2003-07-13  9:13 UTC (permalink / raw)
  To: gdb-patches

There is no implicit alignment of the text section on ppc, so without
an explicit alignment it may end up on a unaligned address (due to a
preceding unaligned .dynstr section).

OK for mainline and 6.0 branch?

Andreas.

2003-07-13  Andreas Schwab  <schwab@suse.de>

	* gdb.asm/powerpc.inc (gdbasm_startup): Force alignment.

--- gdb/testsuite/gdb.asm/powerpc.inc.~1.1.~	2002-04-05 04:48:33.000000000 +0200
+++ gdb/testsuite/gdb.asm/powerpc.inc	2003-07-13 11:00:08.000000000 +0200
@@ -36,6 +36,7 @@
 
 	comment "crt0 startup"
 	.macro gdbasm_startup
+	.p2align 2
 	.endm
 
 	comment "Declare a data variable"


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Fix asm-source.exp for ppc
  2003-07-13  9:13 [RFA] Fix asm-source.exp for ppc Andreas Schwab
@ 2003-07-18 14:10 ` Andrew Cagney
  2003-07-21 23:56   ` Kevin Buettner
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2003-07-18 14:10 UTC (permalink / raw)
  To: Andreas Schwab, Kevin Buettner; +Cc: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

Kevin, any problems with this?  You know PPC.

Andrew

[-- Attachment #2: mailbox-message://ac131313@movemail/fsf/gdb/patches#2980122 --]
[-- Type: message/rfc822, Size: 3759 bytes --]

From: Andreas Schwab <schwab@suse.de>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Fix asm-source.exp for ppc
Date: Sun, 13 Jul 2003 11:13:08 +0200
Message-ID: <m3y8z2yel7.fsf@whitebox.as.local>

There is no implicit alignment of the text section on ppc, so without
an explicit alignment it may end up on a unaligned address (due to a
preceding unaligned .dynstr section).

OK for mainline and 6.0 branch?

Andreas.

2003-07-13  Andreas Schwab  <schwab@suse.de>

	* gdb.asm/powerpc.inc (gdbasm_startup): Force alignment.

--- gdb/testsuite/gdb.asm/powerpc.inc.~1.1.~	2002-04-05 04:48:33.000000000 +0200
+++ gdb/testsuite/gdb.asm/powerpc.inc	2003-07-13 11:00:08.000000000 +0200
@@ -36,6 +36,7 @@
 
 	comment "crt0 startup"
 	.macro gdbasm_startup
+	.p2align 2
 	.endm
 
 	comment "Declare a data variable"


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Fix asm-source.exp for ppc
  2003-07-18 14:10 ` Andrew Cagney
@ 2003-07-21 23:56   ` Kevin Buettner
  0 siblings, 0 replies; 3+ messages in thread
From: Kevin Buettner @ 2003-07-21 23:56 UTC (permalink / raw)
  To: Andrew Cagney, Andreas Schwab, Kevin Buettner; +Cc: gdb-patches

It looks reasonable to me.  I think it should go into both the mainline
and the 6.0 branch.

Kevin

On Jul 18, 10:10am, Andrew Cagney wrote:

> Kevin, any problems with this?  You know PPC.
> 
> Andrew
> 
> To: gdb-patches@sources.redhat.com
> Subject: [RFA] Fix asm-source.exp for ppc
> From: Andreas Schwab <schwab@suse.de>
> Date: Sun, 13 Jul 2003 11:13:08 +0200
> 
> There is no implicit alignment of the text section on ppc, so without
> an explicit alignment it may end up on a unaligned address (due to a
> preceding unaligned .dynstr section).
> 
> OK for mainline and 6.0 branch?
> 
> Andreas.
> 
> 2003-07-13  Andreas Schwab  <schwab@suse.de>
> 
> 	* gdb.asm/powerpc.inc (gdbasm_startup): Force alignment.
> 
> --- gdb/testsuite/gdb.asm/powerpc.inc.~1.1.~	2002-04-05 04:48:33.000000000 +0200
> +++ gdb/testsuite/gdb.asm/powerpc.inc	2003-07-13 11:00:08.000000000 +0200
> @@ -36,6 +36,7 @@
>  
>  	comment "crt0 startup"
>  	.macro gdbasm_startup
> +	.p2align 2
>  	.endm
>  
>  	comment "Declare a data variable"


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-07-21 23:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-07-13  9:13 [RFA] Fix asm-source.exp for ppc Andreas Schwab
2003-07-18 14:10 ` Andrew Cagney
2003-07-21 23:56   ` Kevin Buettner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox