From: Kevin Buettner <kevinb@redhat.com>
To: "J. Johnston" <jjohnstn@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: RFA: patch to convert_doublest_to_floatformat in doublest.c
Date: Wed, 11 Jun 2003 21:20:00 -0000 [thread overview]
Message-ID: <1030611211955.ZM26801@localhost.localdomain> (raw)
In-Reply-To: "J. Johnston" <jjohnstn@redhat.com> "RFA: patch to convert_doublest_to_floatformat in doublest.c" (Jun 10, 3:16pm)
On Jun 10, 3:16pm, J. Johnston wrote:
> The old algorithm is correct for floating values whereby there are
> 32 or more mantissa bits. In such a case, we only can put 31 bits
> into the result. A simple test was added. The patch has been
> tested on the ia64 and x86.
I'm wondering about the test that you added. You say that the old
algorithm was correct for 32 or *more* mantissa bits. Yet the test
you added is as follows:
> + if (mant_bits == 32)
I'm wondering if this should instead be:
if (mant_bits >= 32)
?
Kevin
next prev parent reply other threads:[~2003-06-11 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-10 19:16 J. Johnston
2003-06-11 21:20 ` Kevin Buettner [this message]
2003-06-11 21:25 ` J. Johnston
2003-06-11 22:15 ` Kevin Buettner
2003-06-11 23:35 ` J. Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030611211955.ZM26801@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox