From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-25143-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 13748 invoked by alias); 11 Jun 2003 21:20:03 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 13707 invoked from network); 11 Jun 2003 21:20:02 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 11 Jun 2003 21:20:02 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h5BLK2H15071
	for <gdb-patches@sources.redhat.com>; Wed, 11 Jun 2003 17:20:02 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5BLK1I11485;
	Wed, 11 Jun 2003 17:20:01 -0400
Received: from localhost.localdomain (vpn50-31.rdu.redhat.com [172.16.50.31])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5BLK0E13038;
	Wed, 11 Jun 2003 17:20:00 -0400
Received: (from kev@localhost)
	by localhost.localdomain (8.11.6/8.11.6) id h5BLJto26802;
	Wed, 11 Jun 2003 14:19:55 -0700
Date: Wed, 11 Jun 2003 21:20:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1030611211955.ZM26801@localhost.localdomain>
In-Reply-To: "J. Johnston" <jjohnstn@redhat.com>
        "RFA: patch to convert_doublest_to_floatformat in doublest.c" (Jun 10,  3:16pm)
References: <3EE62E90.1000806@redhat.com>
To: "J. Johnston" <jjohnstn@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: RFA: patch to convert_doublest_to_floatformat in doublest.c
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2003-06/txt/msg00387.txt.bz2

On Jun 10,  3:16pm, J. Johnston wrote:

> The old algorithm is correct for floating values whereby there are
> 32 or more mantissa bits.  In such a case, we only can put 31 bits
> into the result.  A simple test was added.  The patch has been
> tested on the ia64 and x86.

I'm wondering about the test that you added.  You say that the old
algorithm was correct for 32 or *more* mantissa bits.  Yet the test
you added is as follows:

> +          if (mant_bits == 32)

I'm wondering if this should instead be:

             if (mant_bits >= 32)

?

Kevin