From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [patch rfc] s/extract_address/extract_unsigned_integer/ for solib
Date: Thu, 22 May 2003 19:47:00 -0000 [thread overview]
Message-ID: <1030522194129.ZM31026@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "[patch rfc] s/extract_address/extract_unsigned_integer/ for solib" (May 22, 3:01pm)
On May 22, 3:01pm, Andrew Cagney wrote:
> This does the s/extract_address/extract_unsigned_integer/ change to the
> solib files.
>
> One bit bugs me - IRIX. It's doing an unsigned extract when MIPS is
> ment to always sign extend an address. It's very tempting to instead
> make that code always do signextended extracts (I don't have access to
> an IRIX 4 box though).
>
> thoughts?
It looks okay to me.
I agree that extract_mips_address() in solib-irix.c probably ought to
be using extract_signed_integer(), but I too am reluctant to change it
without testing.
Why do you need an IRIX 4 box? Wouldn't IRIX 6 work?
Kevin
next prev parent reply other threads:[~2003-05-22 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 19:01 Andrew Cagney
2003-05-22 19:47 ` Kevin Buettner [this message]
2003-05-23 17:59 ` Andrew Cagney
2003-06-01 23:02 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030522194129.ZM31026@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox