From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31631 invoked by alias); 22 May 2003 19:47:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19912 invoked from network); 22 May 2003 19:41:38 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 May 2003 19:41:38 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h4MJfcH19753 for ; Thu, 22 May 2003 15:41:38 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4MJfZI09506; Thu, 22 May 2003 15:41:35 -0400 Received: from localhost.localdomain (vpn50-3.rdu.redhat.com [172.16.50.3]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h4MJfZo18146; Thu, 22 May 2003 15:41:35 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h4MJfTP31027; Thu, 22 May 2003 12:41:29 -0700 Date: Thu, 22 May 2003 19:47:00 -0000 From: Kevin Buettner Message-Id: <1030522194129.ZM31026@localhost.localdomain> In-Reply-To: Andrew Cagney "[patch rfc] s/extract_address/extract_unsigned_integer/ for solib" (May 22, 3:01pm) References: <3ECD1E75.9020900@redhat.com> To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [patch rfc] s/extract_address/extract_unsigned_integer/ for solib MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-05/txt/msg00438.txt.bz2 On May 22, 3:01pm, Andrew Cagney wrote: > This does the s/extract_address/extract_unsigned_integer/ change to the > solib files. > > One bit bugs me - IRIX. It's doing an unsigned extract when MIPS is > ment to always sign extend an address. It's very tempting to instead > make that code always do signextended extracts (I don't have access to > an IRIX 4 box though). > > thoughts? It looks okay to me. I agree that extract_mips_address() in solib-irix.c probably ought to be using extract_signed_integer(), but I too am reluctant to change it without testing. Why do you need an IRIX 4 box? Wouldn't IRIX 6 work? Kevin