From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Use correct register names for MIPS n32/n64 ABIs
Date: Wed, 19 Mar 2003 06:51:00 -0000 [thread overview]
Message-ID: <1030319065057.ZM29897@localhost.localdomain> (raw)
In-Reply-To: Kevin Buettner <kevinb@redhat.com> "Re: [RFA] Use correct register names for MIPS n32/n64 ABIs" (Mar 18, 11:39pm)
On Mar 18, 11:39pm, Kevin Buettner wrote:
> Hmm... I see that I also got the NUM_REGS check wrong. (It should be
> regno < NUM_REGS, not regno <= NUM_REGS.) I'll check in a one line
> fix for that in a moment.
Okay, here's what I checked in for that fix:
* mips-tdep.c (mips_register_name): Fix fencepost error involving
NUM_REGS bounds check.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.173
diff -u -p -r1.173 mips-tdep.c
--- mips-tdep.c 19 Mar 2003 06:21:13 -0000 1.173
+++ mips-tdep.c 19 Mar 2003 06:39:44 -0000
@@ -402,7 +402,7 @@ mips_register_name (int regno)
else
return mips_gpr_names[regno];
}
- else if (32 <= regno && regno <= NUM_REGS)
+ else if (32 <= regno && regno < NUM_REGS)
return mips_processor_reg_names[regno - 32];
else
internal_error (__FILE__, __LINE__,
prev parent reply other threads:[~2003-03-19 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-18 23:41 Kevin Buettner
2003-03-19 1:46 ` Andrew Cagney
2003-03-19 6:39 ` Kevin Buettner
2003-03-19 6:51 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030319065057.ZM29897@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox