From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11327 invoked by alias); 19 Mar 2003 06:51:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11290 invoked from network); 19 Mar 2003 06:51:05 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 19 Mar 2003 06:51:05 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h2J6p5Q14588 for ; Wed, 19 Mar 2003 01:51:05 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h2J6p4V29467; Wed, 19 Mar 2003 01:51:04 -0500 Received: from localhost.localdomain (vpn50-21.rdu.redhat.com [172.16.50.21]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h2J6p3013023; Wed, 19 Mar 2003 01:51:03 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h2J6owO29898; Tue, 18 Mar 2003 23:50:58 -0700 Date: Wed, 19 Mar 2003 06:51:00 -0000 From: Kevin Buettner Message-Id: <1030319065057.ZM29897@localhost.localdomain> In-Reply-To: Kevin Buettner "Re: [RFA] Use correct register names for MIPS n32/n64 ABIs" (Mar 18, 11:39pm) References: <1030318234150.ZM25965@localhost.localdomain> <3E77CBE4.4090009@redhat.com> <1030319063922.ZM28691@localhost.localdomain> To: Andrew Cagney Subject: Re: [RFA] Use correct register names for MIPS n32/n64 ABIs Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-03/txt/msg00419.txt.bz2 On Mar 18, 11:39pm, Kevin Buettner wrote: > Hmm... I see that I also got the NUM_REGS check wrong. (It should be > regno < NUM_REGS, not regno <= NUM_REGS.) I'll check in a one line > fix for that in a moment. Okay, here's what I checked in for that fix: * mips-tdep.c (mips_register_name): Fix fencepost error involving NUM_REGS bounds check. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.173 diff -u -p -r1.173 mips-tdep.c --- mips-tdep.c 19 Mar 2003 06:21:13 -0000 1.173 +++ mips-tdep.c 19 Mar 2003 06:39:44 -0000 @@ -402,7 +402,7 @@ mips_register_name (int regno) else return mips_gpr_names[regno]; } - else if (32 <= regno && regno <= NUM_REGS) + else if (32 <= regno && regno < NUM_REGS) return mips_processor_reg_names[regno - 32]; else internal_error (__FILE__, __LINE__,