From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Replace complain() with complaint()
Date: Fri, 13 Dec 2002 15:20:00 -0000 [thread overview]
Message-ID: <1021213221822.ZM13404@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "Re: [RFC] Replace complain() with complaint()" (Dec 13, 4:49pm)
On Dec 13, 4:49pm, Andrew Cagney wrote:
> > Okay, now I see a -Wformat warning. Fortunately, buildsym.c was the only
> > file affected. Below are the diffs that I propose using for that file.
> > (These take the place of the buildsym.c diffs that I previously posted.)
> > The ChangeLog entries remain the same.
>
> Ok. Out of interest, how many other problems did the first pass find?
Perhaps a dozen. There were several cases of int formats with long
arguments. Also, there were a number of cases in which complain() was
being called with an incorrect number of arguments (for the format
string).
So the new interface did indeed catch a number of problems.
Kevin
next prev parent reply other threads:[~2002-12-13 22:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-11 21:18 Kevin Buettner
2002-12-13 12:34 ` Andrew Cagney
2002-12-13 12:44 ` Kevin Buettner
2002-12-13 13:18 ` Kevin Buettner
2002-12-13 13:59 ` Andrew Cagney
2002-12-13 15:20 ` Kevin Buettner [this message]
2002-12-16 17:23 ` Kevin Buettner
2002-12-17 4:28 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1021213221822.ZM13404@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox