From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11336 invoked by alias); 13 Dec 2002 22:18:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11320 invoked from network); 13 Dec 2002 22:18:33 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 13 Dec 2002 22:18:33 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gBDLqhP28465 for ; Fri, 13 Dec 2002 16:52:43 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBDMITD09336; Fri, 13 Dec 2002 17:18:29 -0500 Received: from localhost.localdomain (vpn50-3.rdu.redhat.com [172.16.50.3]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBDMISY09770; Fri, 13 Dec 2002 17:18:28 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id gBDMINk13405; Fri, 13 Dec 2002 15:18:23 -0700 Date: Fri, 13 Dec 2002 15:20:00 -0000 From: Kevin Buettner Message-Id: <1021213221822.ZM13404@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [RFC] Replace complain() with complaint()" (Dec 13, 4:49pm) References: <1021212043633.ZM12225@localhost.localdomain> <3DFA412D.4030409@redhat.com> <1021213203820.ZM21776@localhost.localdomain> <1021213211537.ZM13136@localhost.localdomain> <3DFA55CF.4050203@redhat.com> To: Andrew Cagney Subject: Re: [RFC] Replace complain() with complaint() Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-12/txt/msg00440.txt.bz2 On Dec 13, 4:49pm, Andrew Cagney wrote: > > Okay, now I see a -Wformat warning. Fortunately, buildsym.c was the only > > file affected. Below are the diffs that I propose using for that file. > > (These take the place of the buildsym.c diffs that I previously posted.) > > The ChangeLog entries remain the same. > > Ok. Out of interest, how many other problems did the first pass find? Perhaps a dozen. There were several cases of int formats with long arguments. Also, there were a number of cases in which complain() was being called with an incorrect number of arguments (for the format string). So the new interface did indeed catch a number of problems. Kevin