From: Kevin Buettner <kevinb@redhat.com>
To: Adam Fedor <fedor@doc.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] ARI fixes fro objc-lang.[ch]
Date: Thu, 03 Oct 2002 16:50:00 -0000 [thread overview]
Message-ID: <1021003235018.ZM30016@localhost.localdomain> (raw)
In-Reply-To: Adam Fedor <fedor@doc.com> "[PATCH] ARI fixes fro objc-lang.[ch]" (Oct 2, 8:42pm)
On Oct 2, 8:42pm, Adam Fedor wrote:
> 2002-10-02 Adam Fedor <fedor@gnu.org>
>
> * objc-lang.c: ARI fixes. Change string.h to gdb_string.h
> (objc_demangle): Remove assignment in if statements, free->xfree
> (add_msglist): Likewise.
> (end_msglist): Likewise.
> (complare_selectors): Likewise.
> (selectors_info): Likewise.
> (compare_classes): Likewise.
> (classes_info): Likewise.
> (print_object_command): Likewise.
> (find_objc_msgcall_submethod): PTR->void *
> * objc-lang.h: Remove check for __STDC__
The patch looks good to me. I think it's okay to check it in.
Regarding the format of your ChangeLog entries though...
1) Check your ChangeLog entry indentation. It looks to me like
you're indenting by nine spaces. (A single tab is usually
used, though there are a few entries scattered about which
use eight spaces instead.)
2) Make sure that each sentence ends with a period.
3) If a period does not end the line, make sure that there are
two spaces between it and the next non-blank character.
4) [Now I'm really picking at nits...] I'd rather see:
(find_objc_msgcall_submethod): Replace ``PTR'' with ``void *''.
instead of:
(find_objc_msgcall_submethod): PTR->void *.
Kevin
next prev parent reply other threads:[~2002-10-03 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-02 19:42 Adam Fedor
2002-10-03 16:50 ` Kevin Buettner [this message]
2002-10-08 16:24 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1021003235018.ZM30016@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=fedor@doc.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox