From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31591 invoked by alias); 3 Oct 2002 23:50:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31583 invoked from network); 3 Oct 2002 23:50:29 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 3 Oct 2002 23:50:29 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g93NVN001936 for ; Thu, 3 Oct 2002 19:31:23 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g93NoOf19563; Thu, 3 Oct 2002 19:50:24 -0400 Received: from localhost.localdomain (vpn50-3.rdu.redhat.com [172.16.50.3]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g93NoO908166; Thu, 3 Oct 2002 19:50:24 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id g93NoID30017; Thu, 3 Oct 2002 16:50:18 -0700 Date: Thu, 03 Oct 2002 16:50:00 -0000 From: Kevin Buettner Message-Id: <1021003235018.ZM30016@localhost.localdomain> In-Reply-To: Adam Fedor "[PATCH] ARI fixes fro objc-lang.[ch]" (Oct 2, 8:42pm) References: <3D9BAE8E.7000804@doc.com> To: Adam Fedor , gdb-patches@sources.redhat.com Subject: Re: [PATCH] ARI fixes fro objc-lang.[ch] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-10/txt/msg00117.txt.bz2 On Oct 2, 8:42pm, Adam Fedor wrote: > 2002-10-02 Adam Fedor > > * objc-lang.c: ARI fixes. Change string.h to gdb_string.h > (objc_demangle): Remove assignment in if statements, free->xfree > (add_msglist): Likewise. > (end_msglist): Likewise. > (complare_selectors): Likewise. > (selectors_info): Likewise. > (compare_classes): Likewise. > (classes_info): Likewise. > (print_object_command): Likewise. > (find_objc_msgcall_submethod): PTR->void * > * objc-lang.h: Remove check for __STDC__ The patch looks good to me. I think it's okay to check it in. Regarding the format of your ChangeLog entries though... 1) Check your ChangeLog entry indentation. It looks to me like you're indenting by nine spaces. (A single tab is usually used, though there are a few entries scattered about which use eight spaces instead.) 2) Make sure that each sentence ends with a period. 3) If a period does not end the line, make sure that there are two spaces between it and the next non-blank character. 4) [Now I'm really picking at nits...] I'd rather see: (find_objc_msgcall_submethod): Replace ``PTR'' with ``void *''. instead of: (find_objc_msgcall_submethod): PTR->void *. Kevin