* [RFA] annota1.exp: Don't require complete pathname in info break test
@ 2002-07-29 14:01 Kevin Buettner
2002-09-25 11:28 ` Fernando Nasser
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2002-07-29 14:01 UTC (permalink / raw)
To: gdb-patches
While testing with the IRIX compiler, I found it necessary to make the
change below in order for the test to pass. I think it's reasonable for
this test to still pass even if the pathname in question isn't completely
qualified.
Okay to commit?
* gdb.base/annota1.exp (info break): Make directory components of
path optional since not all compilers emit this debug information.
Index: testsuite/gdb.base/annota1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v
retrieving revision 1.10
diff -u -p -r1.10 annota1.exp
--- testsuite/gdb.base/annota1.exp 18 Apr 2002 22:17:01 -0000 1.10
+++ testsuite/gdb.base/annota1.exp 29 Jul 2002 20:37:59 -0000
@@ -115,7 +115,7 @@ gdb_expect {
#
send_gdb "info break\n"
gdb_expect {
- -re "\r\n\032\032post-prompt\r\n\r\n\032\032breakpoints-headers\r\n\r\n\032\032field 0\r\nNum \r\n\032\032field 1\r\nType \r\n\032\032field 2\r\nDisp \r\n\032\032field 3\r\nEnb \r\n\032\032field 4\r\nAddress +\r\n\032\032field 5\r\nWhat\r\n\r\n\032\032breakpoints-table\r\n\r\n\032\032record\r\n\r\n\032\032field 0\r\n1 \r\n\032\032field 1\r\nbreakpoint \r\n\032\032field 2\r\nkeep \r\n\032\032field 3\r\ny \r\n\032\032field 4\r\n$hex +\r\n\032\032field 5\r\nin main at ${srcdir}/${subdir}/${srcfile}:$main_line\r\n\r\n\032\032breakpoints-table-end\r\n$gdb_prompt$" \
+ -re "\r\n\032\032post-prompt\r\n\r\n\032\032breakpoints-headers\r\n\r\n\032\032field 0\r\nNum \r\n\032\032field 1\r\nType \r\n\032\032field 2\r\nDisp \r\n\032\032field 3\r\nEnb \r\n\032\032field 4\r\nAddress +\r\n\032\032field 5\r\nWhat\r\n\r\n\032\032breakpoints-table\r\n\r\n\032\032record\r\n\r\n\032\032field 0\r\n1 \r\n\032\032field 1\r\nbreakpoint \r\n\032\032field 2\r\nkeep \r\n\032\032field 3\r\ny \r\n\032\032field 4\r\n$hex +\r\n\032\032field 5\r\nin main at (${srcdir}/${subdir}/)?${srcfile}:$main_line\r\n\r\n\032\032breakpoints-table-end\r\n$gdb_prompt$" \
{pass "breakpoint info"}
-re ".*$gdb_prompt$" { fail "breakpoint info" }
timeout { fail "breakpoint info (timeout)" }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] annota1.exp: Don't require complete pathname in info break test
2002-07-29 14:01 [RFA] annota1.exp: Don't require complete pathname in info break test Kevin Buettner
@ 2002-09-25 11:28 ` Fernando Nasser
2002-09-27 18:16 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: Fernando Nasser @ 2002-09-25 11:28 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
I guess we can't require something that may not be there.
Pls. check it in.
Regards,
Fernando
Kevin Buettner wrote:
> While testing with the IRIX compiler, I found it necessary to make the
> change below in order for the test to pass. I think it's reasonable for
> this test to still pass even if the pathname in question isn't completely
> qualified.
>
> Okay to commit?
>
> * gdb.base/annota1.exp (info break): Make directory components of
> path optional since not all compilers emit this debug information.
>
> Index: testsuite/gdb.base/annota1.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v
> retrieving revision 1.10
> diff -u -p -r1.10 annota1.exp
> --- testsuite/gdb.base/annota1.exp 18 Apr 2002 22:17:01 -0000 1.10
> +++ testsuite/gdb.base/annota1.exp 29 Jul 2002 20:37:59 -0000
> @@ -115,7 +115,7 @@ gdb_expect {
> #
> send_gdb "info break\n"
> gdb_expect {
> - -re "\r\n\032\032post-prompt\r\n\r\n\032\032breakpoints-headers\r\n\r\n\032\032field 0\r\nNum \r\n\032\032field 1\r\nType \r\n\032\032field 2\r\nDisp \r\n\032\032field 3\r\nEnb \r\n\032\032field 4\r\nAddress +\r\n\032\032field 5\r\nWhat\r\n\r\n\032\032breakpoints-table\r\n\r\n\032\032record\r\n\r\n\032\032field 0\r\n1 \r\n\032\032field 1\r\nbreakpoint \r\n\032\032field 2\r\nkeep \r\n\032\032field 3\r\ny \r\n\032\032field 4\r\n$hex +\r\n\032\032field 5\r\nin main at ${srcdir}/${subdir}/${srcfile}:$main_line\r\n\r\n\032\032breakpoints-table-end\r\n$gdb_prompt$" \
> + -re "\r\n\032\032post-prompt\r\n\r\n\032\032breakpoints-headers\r\n\r\n\032\032field 0\r\nNum \r\n\032\032field 1\r\nType \r\n\032\032field 2\r\nDisp \r\n\032\032field 3\r\nEnb \r\n\032\032field 4\r\nAddress +\r\n\032\032field 5\r\nWhat\r\n\r\n\032\032breakpoints-table\r\n\r\n\032\032record\r\n\r\n\032\032field 0\r\n1 \r\n\032\032field 1\r\nbreakpoint \r\n\032\032field 2\r\nkeep \r\n\032\032field 3\r\ny \r\n\032\032field 4\r\n$hex +\r\n\032\032field 5\r\nin main at (${srcdir}/${subdir}/)?${srcfile}:$main_line\r\n\r\n\032\032breakpoints-table-end\r\n$gdb_prompt$" \
> {pass "breakpoint info"}
> -re ".*$gdb_prompt$" { fail "breakpoint info" }
> timeout { fail "breakpoint info (timeout)" }
>
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] annota1.exp: Don't require complete pathname in info break test
2002-09-25 11:28 ` Fernando Nasser
@ 2002-09-27 18:16 ` Kevin Buettner
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Buettner @ 2002-09-27 18:16 UTC (permalink / raw)
To: Fernando Nasser, Kevin Buettner; +Cc: gdb-patches
On Sep 25, 2:28pm, Fernando Nasser wrote:
> I guess we can't require something that may not be there.
>
> Pls. check it in.
Committed.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-09-28 1:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-29 14:01 [RFA] annota1.exp: Don't require complete pathname in info break test Kevin Buettner
2002-09-25 11:28 ` Fernando Nasser
2002-09-27 18:16 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox