From: Kevin Buettner <kevinb@redhat.com>
To: Keith Seitz <keiths@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFC/A] gdb/680: ui_out_reset?
Date: Wed, 11 Sep 2002 12:36:00 -0000 [thread overview]
Message-ID: <1020911193617.ZM12554@localhost.localdomain> (raw)
In-Reply-To: Keith Seitz <keiths@redhat.com> "Re: [RFC/A] gdb/680: ui_out_reset?" (Sep 11, 12:15pm)
On Sep 11, 12:15pm, Keith Seitz wrote:
> In this case, the register commands (and probably a lot of other commands,
> too) are just plain programmed wrong. They should be using
> make_cleanup_ui_out_list/tuple_begin_end instead of
> ui_out_list/tuple_begin and ui_out_list/tuple_end.
>
> How's this patch look? It doesn't cause an regressions and fixes gdb/680.
> Keith
>
> ChangeLog
> 2002-09-11 Keith Seitz <keiths@redhat.com>
>
> * mi-main.c (mi_cmd_data_list_register_names): Use cleanups
> for the uiout list. Do the cleanups when returning an error.
> (mi_cmd_data_list_changed_registers): Ditto.
> (mi_cmd_data_list_register_values): Use cleanups for the uiout list
> and tuples. Do the cleanups when returning errors.
Looks good to me.
(Since this is also the approach that I took, I'll commit my patches
too.)
Kevin
next prev parent reply other threads:[~2002-09-11 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-10 16:41 Keith Seitz
2002-09-10 17:29 ` Kevin Buettner
2002-09-10 17:36 ` Kevin Buettner
2002-09-11 12:12 ` Keith Seitz
2002-09-11 12:36 ` Kevin Buettner [this message]
2002-09-11 14:29 ` Elena Zannoni
2002-09-11 14:39 ` Keith Seitz
2002-09-11 14:45 ` Elena Zannoni
2002-09-11 14:49 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020911193617.ZM12554@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox