From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27259 invoked by alias); 11 Sep 2002 19:36:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27252 invoked from network); 11 Sep 2002 19:36:24 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Sep 2002 19:36:24 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g8BJJtw28982 for ; Wed, 11 Sep 2002 15:19:55 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8BJaKd02834; Wed, 11 Sep 2002 15:36:20 -0400 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g8BJaJC22779; Wed, 11 Sep 2002 12:36:19 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g8BJaHO12555; Wed, 11 Sep 2002 12:36:17 -0700 Date: Wed, 11 Sep 2002 12:36:00 -0000 From: Kevin Buettner Message-Id: <1020911193617.ZM12554@localhost.localdomain> In-Reply-To: Keith Seitz "Re: [RFC/A] gdb/680: ui_out_reset?" (Sep 11, 12:15pm) References: To: Keith Seitz , gdb-patches@sources.redhat.com Subject: Re: [RFC/A] gdb/680: ui_out_reset? MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-09/txt/msg00188.txt.bz2 On Sep 11, 12:15pm, Keith Seitz wrote: > In this case, the register commands (and probably a lot of other commands, > too) are just plain programmed wrong. They should be using > make_cleanup_ui_out_list/tuple_begin_end instead of > ui_out_list/tuple_begin and ui_out_list/tuple_end. > > How's this patch look? It doesn't cause an regressions and fixes gdb/680. > Keith > > ChangeLog > 2002-09-11 Keith Seitz > > * mi-main.c (mi_cmd_data_list_register_names): Use cleanups > for the uiout list. Do the cleanups when returning an error. > (mi_cmd_data_list_changed_registers): Ditto. > (mi_cmd_data_list_register_values): Use cleanups for the uiout list > and tuples. Do the cleanups when returning errors. Looks good to me. (Since this is also the approach that I took, I'll commit my patches too.) Kevin