From: Kevin Buettner <kevinb@redhat.com>
To: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: fourth and last patch to aix-thread.c
Date: Mon, 22 Jul 2002 15:30:00 -0000 [thread overview]
Message-ID: <1020722221702.ZM26114@localhost.localdomain> (raw)
In-Reply-To: Michael Snyder <msnyder@redhat.com> "fourth and last patch to aix-thread.c" (Jul 19, 3:46pm)
On Jul 19, 3:46pm, Michael Snyder wrote:
> This is the last one, I promise. I thought some of the identifiers in
> aix-thread
> were a little un-informative and/or inconsistant with other target
> modules, so
> I offer you this renaming.
>
> And I humbly beg your pardon, but I was unable to resist sneaking a few
> whitespace clean-ups in there too. If you like, I'll re-submit them
> separately.
[...]
> * aix-thread.c (ops): Rename to pthdebug_ops.
> (base_ops): Rename to base_target.
> (ops_attach): Rename to pthdebug_attach.
> (ops_detach): Rename to pthdebug_detach.
> (ops_resume): Rename to pthdebug_detach.
> (ops_wait): Rename to pthdebug_wait.
> (ops_kill): Rename to pthdebug_kill.
> (init_ops): Rename to init_pthdebug_ops.
> (ops_fetch_register): Rename to pthdebug_fetch_register.
> (ops_store_register): Rename to pthdebug_store_register.
> (ops_mourn_inferior): Rename to pthdebug_mourn_inferior.
> (ops_thread_alive): Rename to pthdebug_thread_alive.
> (ops_extra_thread_info: Rename to pthdebug_extra_thread_info.
> (ops_pid_to_str): Rename to pthdebug_pid_to_str.
> (ops_xfer_memory): Rename to pthdebug_xfer_memory.
> (fetch_regs_lib): Rename to fetch_regs_user_thread.
> (fetch_regs_kern): Rename to fetch_regs_kernel_thread.
> (store_regs_lib): Rename to store_regs_user_thread.
> (store_regs_kern): Rename to store_regs_kernel_thread.
I've check this in with a couple of modifications:
1) I used ``aix_thread_'' instead of ``pthdebug_''. If you check
lin-lwp.c and thread-db.c, the use of ``aix_thread'' more closely
corresponds (IMO) to what's done in those files.
2) I fixed up a few places where a substition was missed.
Michael, thanks for all the work you did in reviewing and cleaning up
this code. I really appreciate it.
(Now that I've been away from it for a few days and looked at it again,
I've found a few more things that I want to clean up...)
Kevin
prev parent reply other threads:[~2002-07-22 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-19 17:42 Michael Snyder
2002-07-20 10:17 ` Adding %ll to ARI Andrew Cagney
2002-07-23 3:32 ` Kevin Buettner
2002-07-22 15:30 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020722221702.ZM26114@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox