From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19778 invoked by alias); 22 Jul 2002 22:17:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19762 invoked from network); 22 Jul 2002 22:17:05 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 22 Jul 2002 22:17:05 -0000 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6MMHQQ18809; Mon, 22 Jul 2002 15:17:26 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g6MMH2M26115; Mon, 22 Jul 2002 15:17:02 -0700 Date: Mon, 22 Jul 2002 15:30:00 -0000 From: Kevin Buettner Message-Id: <1020722221702.ZM26114@localhost.localdomain> In-Reply-To: Michael Snyder "fourth and last patch to aix-thread.c" (Jul 19, 3:46pm) References: <3D3896DA.7EE844A8@redhat.com> To: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: fourth and last patch to aix-thread.c MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00446.txt.bz2 On Jul 19, 3:46pm, Michael Snyder wrote: > This is the last one, I promise. I thought some of the identifiers in > aix-thread > were a little un-informative and/or inconsistant with other target > modules, so > I offer you this renaming. > > And I humbly beg your pardon, but I was unable to resist sneaking a few > whitespace clean-ups in there too. If you like, I'll re-submit them > separately. [...] > * aix-thread.c (ops): Rename to pthdebug_ops. > (base_ops): Rename to base_target. > (ops_attach): Rename to pthdebug_attach. > (ops_detach): Rename to pthdebug_detach. > (ops_resume): Rename to pthdebug_detach. > (ops_wait): Rename to pthdebug_wait. > (ops_kill): Rename to pthdebug_kill. > (init_ops): Rename to init_pthdebug_ops. > (ops_fetch_register): Rename to pthdebug_fetch_register. > (ops_store_register): Rename to pthdebug_store_register. > (ops_mourn_inferior): Rename to pthdebug_mourn_inferior. > (ops_thread_alive): Rename to pthdebug_thread_alive. > (ops_extra_thread_info: Rename to pthdebug_extra_thread_info. > (ops_pid_to_str): Rename to pthdebug_pid_to_str. > (ops_xfer_memory): Rename to pthdebug_xfer_memory. > (fetch_regs_lib): Rename to fetch_regs_user_thread. > (fetch_regs_kern): Rename to fetch_regs_kernel_thread. > (store_regs_lib): Rename to store_regs_user_thread. > (store_regs_kern): Rename to store_regs_kernel_thread. I've check this in with a couple of modifications: 1) I used ``aix_thread_'' instead of ``pthdebug_''. If you check lin-lwp.c and thread-db.c, the use of ``aix_thread'' more closely corresponds (IMO) to what's done in those files. 2) I fixed up a few places where a substition was missed. Michael, thanks for all the work you did in reviewing and cleaning up this code. I really appreciate it. (Now that I've been away from it for a few days and looked at it again, I've found a few more things that I want to clean up...) Kevin