From: Kevin Buettner <kevinb@redhat.com>
To: Grace Sainsbury <graces@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] more m68k multi-arch
Date: Fri, 28 Jun 2002 11:04:00 -0000 [thread overview]
Message-ID: <1020628180358.ZM26305@localhost.localdomain> (raw)
In-Reply-To: Grace Sainsbury <graces@redhat.com> "[PATCH] more m68k multi-arch" (Jun 24, 1:10pm)
On Jun 24, 1:10pm, Grace Sainsbury wrote:
> +#if !GDB_MULTI_ARCH
> #define STORE_STRUCT_RETURN(ADDR, SP) \
> { write_register (A1_REGNUM, (ADDR)); }
>
> @@ -221,11 +228,13 @@
> (TYPE_LENGTH(TYPE) >= 4 ? 0 : 4 - TYPE_LENGTH(TYPE)), \
> TYPE_LENGTH(TYPE))
> #endif
> +#endif //multi-arch
I've noticed the addition of a number of ``#if !GDB_MULTI_ARCH''
statements in your patch. Presumably, these are temporary until
you finish the job, right? (I'm wondering if it's necessary to
keep them around at all.)
Also... be careful with // comments. While these do work with gcc,
they don't work with all C compilers, so use /* ... */ instead.
Kevin
next prev parent reply other threads:[~2002-06-28 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-24 10:10 Grace Sainsbury
2002-06-28 11:04 ` Kevin Buettner [this message]
2002-06-28 11:27 ` Kevin Buettner
2002-07-10 16:04 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020628180358.ZM26305@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=graces@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox