From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16155 invoked by alias); 28 Jun 2002 18:04:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16140 invoked from network); 28 Jun 2002 18:04:01 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 28 Jun 2002 18:04:01 -0000 Received: from romulus.sfbay.redhat.com (IDENT:E4uXIrIvvAvZex3+dhoti2kHiheJSe7Z@romulus.sfbay.redhat.com [172.16.27.251]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g5SI5JQ31066; Fri, 28 Jun 2002 11:05:20 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g5SI3wi26306; Fri, 28 Jun 2002 11:03:58 -0700 Date: Fri, 28 Jun 2002 11:04:00 -0000 From: Kevin Buettner Message-Id: <1020628180358.ZM26305@localhost.localdomain> In-Reply-To: Grace Sainsbury "[PATCH] more m68k multi-arch" (Jun 24, 1:10pm) References: <20020624131028.A1510@tomago.toronto.redhat.com> To: Grace Sainsbury , gdb-patches@sources.redhat.com Subject: Re: [PATCH] more m68k multi-arch MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-06/txt/msg00569.txt.bz2 On Jun 24, 1:10pm, Grace Sainsbury wrote: > +#if !GDB_MULTI_ARCH > #define STORE_STRUCT_RETURN(ADDR, SP) \ > { write_register (A1_REGNUM, (ADDR)); } > > @@ -221,11 +228,13 @@ > (TYPE_LENGTH(TYPE) >= 4 ? 0 : 4 - TYPE_LENGTH(TYPE)), \ > TYPE_LENGTH(TYPE)) > #endif > +#endif //multi-arch I've noticed the addition of a number of ``#if !GDB_MULTI_ARCH'' statements in your patch. Presumably, these are temporary until you finish the job, right? (I'm wondering if it's necessary to keep them around at all.) Also... be careful with // comments. While these do work with gcc, they don't work with all C compilers, so use /* ... */ instead. Kevin