From: Kevin Buettner <kevinb@redhat.com>
To: Jason R Thorpe <thorpej@wasabisystems.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Generic OS ABI handling for PowerPC
Date: Wed, 29 May 2002 17:37:00 -0000 [thread overview]
Message-ID: <1020530002323.ZM4788@localhost.localdomain> (raw)
In-Reply-To: Jason R Thorpe <thorpej@wasabisystems.com> "Re: [PATCH/RFA] Generic OS ABI handling for PowerPC" (May 28, 5:26pm)
On May 28, 5:26pm, Jason R Thorpe wrote:
> Ok, new patch. Moves the ppc_sysv stuff into new ppc-sysv-tdep.c,
> and updates the various .mt files. I also touched up some dependency
> lists in Makefile.in.
>
> OK to commit?
Sure, go ahead.
The only nit I have is with parts of your ChangeLog entry. Entries like
this one...
> * ppc-linux-tdep.c (_initialize_ppc_linux_tdep,
> ppc_linux_init_abi): New functions.
> (ppc_sysv_abi_broken_use_struct_convention,
> ppc_sysv_abi_use_struct_convention,
> ppc_sysv_abi_push_arguments): Move to...
...should be formatted as follows:
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep)
(ppc_linux_init_abi): New functions.
(ppc_sysv_abi_broken_use_struct_convention)
(ppc_sysv_abi_use_struct_convention)
(ppc_sysv_abi_push_arguments): Move to...
(Actually, I prefer the way you did it, but I've been told that it's
incorrect.)
Kevin
next prev parent reply other threads:[~2002-05-30 0:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-28 12:41 Jason R Thorpe
2002-05-28 12:52 ` Kevin Buettner
2002-05-28 13:46 ` Jason R Thorpe
2002-05-28 14:12 ` Kevin Buettner
2002-05-28 16:35 ` Jason R Thorpe
2002-05-28 16:46 ` Kevin Buettner
2002-05-28 16:47 ` Jason R Thorpe
2002-05-28 19:42 ` Andrew Cagney
2002-05-28 17:59 ` Jason R Thorpe
2002-05-29 17:37 ` Kevin Buettner [this message]
2002-05-29 19:08 ` Jason R Thorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020530002323.ZM4788@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=thorpej@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox